43 lines
1.8 KiB
Markdown
43 lines
1.8 KiB
Markdown
---
|
|
id: TASK-34
|
|
title: Harden v3 selection and Convex payloads
|
|
status: In Progress
|
|
assignee: []
|
|
created_date: '2026-06-06 20:54'
|
|
updated_date: '2026-06-06 21:03'
|
|
labels: []
|
|
dependencies: []
|
|
priority: high
|
|
ordinal: 36000
|
|
---
|
|
|
|
## Description
|
|
|
|
<!-- SECTION:DESCRIPTION:BEGIN -->
|
|
Fix v3 quality review issues by removing explicit undefined values from Convex mutation payloads and making v3 skill selection registry-driven with negative applicability tests.
|
|
<!-- SECTION:DESCRIPTION:END -->
|
|
|
|
## Acceptance Criteria
|
|
<!-- AC:BEGIN -->
|
|
- [x] #1 Convex mutation payloads in auditGenerationAction omit undefined top-level and nested fields
|
|
- [x] #2 v3 skill selection is registry-driven by applies_when and declared inputs with deterministic capped output
|
|
- [x] #3 Negative v3 input/applicability tests and legacy category tests pass
|
|
<!-- AC:END -->
|
|
|
|
## Implementation Plan
|
|
|
|
<!-- SECTION:PLAN:BEGIN -->
|
|
1. Inspect current Convex mutation payload construction and v3 selection
|
|
2. Add RED tests for no undefined payload patterns, negative v3 gating, and deterministic cap
|
|
3. Run focused tests and record RED failures
|
|
4. Implement minimal payload omission and registry-driven v3 selection
|
|
5. Run focused tests green plus pnpm test if fast
|
|
6. Self-review scope and leave task In Progress
|
|
<!-- SECTION:PLAN:END -->
|
|
|
|
## Implementation Notes
|
|
|
|
<!-- SECTION:NOTES:BEGIN -->
|
|
RED: tsc passed, focused node --test .test-output/tests/audit-evidence.test.js .test-output/tests/audit-generation-action-source.test.js failed as expected on registry-order v3 cap and explicit undefined stage payload contract. GREEN: tsc passed; focused tests passed 26/26; full pnpm test passed 350/350. Self-review: no commits/staging, no changes to convex/usageEvents.ts, no ScreenshotOne missing-key behavior changes.
|
|
<!-- SECTION:NOTES:END -->
|