44 lines
2.6 KiB
Markdown
44 lines
2.6 KiB
Markdown
---
|
|
id: TASK-48
|
|
title: Integrate impeccable critique into audit pipeline
|
|
status: In Progress
|
|
assignee: []
|
|
created_date: '2026-06-08 12:02'
|
|
updated_date: '2026-06-08 12:10'
|
|
labels: []
|
|
dependencies: []
|
|
priority: high
|
|
ordinal: 50000
|
|
---
|
|
|
|
## Description
|
|
|
|
<!-- SECTION:DESCRIPTION:BEGIN -->
|
|
Extend the evidence-first audit pipeline with design critique/impeccable-style visual and UX evaluation, especially the critique skill, while keeping verified findings evidence-linked and customer-safe.
|
|
<!-- SECTION:DESCRIPTION:END -->
|
|
|
|
## Acceptance Criteria
|
|
<!-- AC:BEGIN -->
|
|
- [x] #1 Critique/impeccable skill guidance is inspected and translated into bounded audit stages or skill prompts
|
|
- [x] #2 New critique findings stay evidence-linked and flow through the compact evidence verifier
|
|
- [x] #3 German copy synthesis consumes only verified critique findings, not raw skill output
|
|
- [x] #4 Audit UI exposes critique findings with evidence chips and actual skill purpose text
|
|
- [x] #5 Focused and full regression tests cover the new critique integration
|
|
<!-- AC:END -->
|
|
|
|
## Implementation Plan
|
|
|
|
<!-- SECTION:PLAN:BEGIN -->
|
|
1. Inspect impeccable/critique skill guidance and current audit pipeline shape
|
|
2. Define a compact critique/impeccable stage that maps skill guidance into evidence-backed audit findings
|
|
3. Add schemas/prompts or stage wiring without expanding verifier output size
|
|
4. Update UI/tests so critique findings are visible with evidence and real skill purpose
|
|
5. Run focused and full regression tests, deploy Convex dev, keep task In Progress for live confirmation
|
|
<!-- SECTION:PLAN:END -->
|
|
|
|
## Implementation Notes
|
|
|
|
<!-- SECTION:NOTES:BEGIN -->
|
|
Implemented the impeccable/critique integration as an evidence-bound audit extension. Inspected the local impeccable and critique skills; no project-specific .impeccable.md was present, so the product guidance was translated into bounded audit behavior instead of broad design taste claims. Added the V3 skill registry entry `impeccable-critique`, prioritized it in selected local audit skills, and wired a new Convex `critiqueSpecialist` stage between visual trust and performance/accessibility. The stage is instructed to produce only evidence-linked findings using skillId `impeccable-critique`; the existing compact verifier and German synthesis path remain the gate, so raw specialist output is not customer-facing. UI tests continue to cover evidence chips and real registry purpose text. Verification: focused specialist/evidence tests 45/45 passed; skill/UI tests 15/15 passed; full `pnpm test` 388/388 passed; `git diff --check` passed; targeted ESLint passed; `npx convex dev --once` synced successfully.
|
|
<!-- SECTION:NOTES:END -->
|