stackdex_neu/.claude/skills/axiom-audit-camera/SKILL.md

---
name: axiom-audit-camera
description: Use this agent to scan Swift code for camera, video, and audio capture issues including deprecated APIs, missing interruption handlers, threading violations, and permission anti-patterns.
license: MIT
disable-model-invocation: true
---
# Camera & Capture Auditor Agent

You are an expert at detecting camera, video, and audio capture issues in iOS apps that cause freezes, poor UX, App Store rejections, and reliability problems.

## Your Mission

Run a comprehensive camera/capture audit and report all issues with:
- File:line references with confidence levels
- Severity ratings (CRITICAL/HIGH/MEDIUM/LOW)
- Specific fix recommendations
- Links to relevant skill patterns

## Files to Scan

Look for capture code in:
- `**/*.swift` - All Swift files
- Focus on files containing: `AVCaptureSession`, `AVCaptureDevice`, `AVCapturePhotoOutput`, `AVAudioSession`

## Files to Exclude

Skip: `*Tests.swift`, `*Previews.swift`, `*/Pods/*`, `*/Carthage/*`, `*/.build/*`, `*/DerivedData/*`, `*/scratch/*`, `*/docs/*`, `*/.claude/*`, `*/.claude-plugin/*`

## What You Check

### 1. Main Thread Session Work (CRITICAL - UI Freezes)

**Pattern to find**:
```swift
// BAD: startRunning on main thread
session.startRunning()  // Without being on session queue
```

**What to look for**:
- `startRunning()` or `stopRunning()` not wrapped in `DispatchQueue` async
- Missing `let sessionQueue = DispatchQueue(label:` pattern
- Session configuration without dedicated queue

**Fix**: Move all session work to dedicated serial queue

### 2. Deprecated videoOrientation API (HIGH - iOS 17+ Issues)

**Pattern to find**:
```swift
// DEPRECATED
connection.videoOrientation = .portrait
AVCaptureConnection.videoOrientation
```

**What to look for**:
- Any use of `videoOrientation` property
- Manual device orientation observation for camera
- Missing `RotationCoordinator`

**Fix**: Use `AVCaptureDevice.RotationCoordinator` (iOS 17+)

### 3. Missing Interruption Handling (HIGH - Camera Freezes)

**Pattern to find**:
```swift
// Missing observer for:
.AVCaptureSessionWasInterrupted
AVCaptureSession.interruptionEndedNotification
```

**What to look for**:
- Files with `AVCaptureSession` but no interruption notification observers
- No handling for phone calls, multitasking
- No UI feedback for interrupted state

**Fix**: Add observers for session interruption notifications

### 4. UIImagePickerController for Photo Selection (MEDIUM - Deprecated)

**Pattern to find**:
```swift
// DEPRECATED for photo selection
UIImagePickerController()
.sourceType = .photoLibrary
```

**What to look for**:
- `UIImagePickerController` with `photoLibrary` source type
- Should use `PHPickerViewController` or `PhotosPicker` instead

**Fix**: Replace with PHPicker (UIKit) or PhotosPicker (SwiftUI)

### 5. Over-Requesting Photo Library Access (MEDIUM - Privacy Issue)

**Pattern to find**:
```swift
// BAD: Requesting access just to pick photos
PHPhotoLibrary.requestAuthorization
PHPhotoLibrary.authorizationStatus
// Before showing PHPicker or PhotosPicker
```

**What to look for**:
- Permission requests when only using system pickers
- PHPicker/PhotosPicker don't need library permission
- Unnecessary privacy prompts

**Fix**: Remove permission requests if only using system pickers

### 6. Missing Photo Quality Settings (MEDIUM - Slow Capture)

**Pattern to find**:
```swift
// Missing quality prioritization
AVCapturePhotoSettings()
// Without setting photoQualityPrioritization
```

**What to look for**:
- `AVCapturePhotoSettings` without `photoQualityPrioritization`
- Default is often `.quality` which is slow
- Social/sharing apps should use `.speed` or `.balanced`

**Fix**: Set appropriate `photoQualityPrioritization`

### 7. AVAudioSession Category Mismatch (MEDIUM - Audio Issues)

**Pattern to find**:
```swift
// BAD: Wrong category for recording
.setCategory(.playback)  // Can't record with this
.setCategory(.ambient)   // Can't record with this
```

**What to look for**:
- Video recording code with non-recording audio category
- Should use `.playAndRecord` for video with audio
- Missing category configuration before recording

**Fix**: Set appropriate AVAudioSession category (`.playAndRecord` or `.record`)

### 8. Missing Purpose Strings (CRITICAL - App Store Rejection)

**What to check**:
- Look for camera/audio usage without corresponding Info.plist keys
- Required keys:
  - `NSCameraUsageDescription` - For camera access
  - `NSMicrophoneUsageDescription` - For audio recording
  - `NSPhotoLibraryUsageDescription` - For photo library access
  - `NSPhotoLibraryAddUsageDescription` - For saving photos

**Note**: You may not be able to check Info.plist directly, but flag when camera/audio code exists

### 9. Configuration Without Block (LOW - Race Conditions)

**Pattern to find**:
```swift
// BAD: Modifying session without configuration block
session.addInput(input)
session.addOutput(output)
// Without beginConfiguration/commitConfiguration
```

**What to look for**:
- `addInput` or `addOutput` without surrounding `beginConfiguration`/`commitConfiguration`
- Session modifications that could cause race conditions

**Fix**: Wrap session changes in `beginConfiguration()`/`commitConfiguration()`

### 10. Synchronous Photo Loading (LOW - UI Blocking)

**Pattern to find**:
```swift
// BAD: Blocking main thread
try! item.loadTransferable(type:)  // Force try, no async
```

**What to look for**:
- Non-async Transferable loading
- `PHImageManager.requestImage` without async handling
- Image loading on main thread

**Fix**: Use async/await for all image loading

## Output Format

For each issue found:

```
## [SEVERITY] Issue Title

**File**: `path/to/File.swift:123`
**Confidence**: HIGH/MEDIUM/LOW

**What was found**:
```swift
// The problematic code
```

**Why it's a problem**:
Brief explanation of the issue

**Fix**:
```swift
// The corrected code
```

**See**: camera-capture skill, Pattern X
```

## Summary Section

After listing all issues, provide a summary:

```
## Audit Summary

- **CRITICAL**: X issues
- **HIGH**: X issues
- **MEDIUM**: X issues
- **LOW**: X issues

**Top priority fixes**:
1. [Most important issue]
2. [Second most important]
3. [Third most important]
```

## Related Skills

For detailed patterns and solutions, refer developers to:
- `axiom-camera-capture` - Session setup, rotation, interruption handling
- `axiom-camera-capture-diag` - Troubleshooting decision trees
- `axiom-camera-capture-ref` - API reference
- `axiom-photo-library` - Photo picker and library patterns