2.2 KiB
id, title, status, assignee, created_date, updated_date, labels, dependencies, priority, ordinal
| id | title | status | assignee | created_date | updated_date | labels | dependencies | priority | ordinal |
|---|---|---|---|---|---|---|---|---|---|
| TASK-35 | Remove remaining undefined audit generation payloads | Done | 2026-06-06 21:06 | 2026-06-10 19:27 | high | 37000 |
Description
Fix TASK-34 spec-review issues by preventing appendRunEvent, success finish, and quality stage calls from sending explicit undefined optional fields.
Acceptance Criteria
- #1 appendRunEvent only sends details when defined
- #2 success finishAuditGenerationRun omits errorSummary instead of sending undefined
- #3 quality-stage persistAuditStage callsite does not pass explicit undefined optional fields
Implementation Plan
- Inspect appendRunEvent, quality persist stage, and success finish call
- Add RED source contracts for remaining explicit undefined patterns
- Run focused tests and record RED
- Implement minimal conditional spreads
- Run focused tests green and full pnpm test if fast
- Self-review scope and leave task In Progress
Implementation Notes
RED: tsc passed. Focused node --test .test-output/tests/audit-generation-action-source.test.js failed as expected on three contracts: appendRunEvent details sent as args.details, success finishAuditGenerationRun ternary errorSummary undefined, and qualityReview persistAuditStage callsite ternary errorSummary undefined.
RED: tsc passed. Focused node --test .test-output/tests/audit-generation-action-source.test.js failed as expected on appendRunEvent details, success finishAuditGenerationRun errorSummary ternary, and qualityReview persistAuditStage errorSummary ternary. GREEN: focused source test passed 21/21; full pnpm test passed 353/353. Self-review: changed only convex/auditGenerationAction.ts and tests/audit-generation-action-source.test.ts in this turn; no commits/staging; no UsageEvents or ScreenshotOne behavior changes.
Final Summary
Closed per explicit user request while switching project tracking to pitchfast.