pitchfast/backlog/tasks/task-34 - Harden-v3-selection-and-Convex-payloads.md

id, title, status, assignee, created_date, updated_date, labels, dependencies, priority, ordinal

id	title	status	assignee	created_date	updated_date	labels	dependencies	priority	ordinal
TASK-34	Harden v3 selection and Convex payloads	In Progress		2026-06-06 20:54	2026-06-06 21:03			high	36000

Description

Fix v3 quality review issues by removing explicit undefined values from Convex mutation payloads and making v3 skill selection registry-driven with negative applicability tests.

Acceptance Criteria

• #1 Convex mutation payloads in auditGenerationAction omit undefined top-level and nested fields
• #2 v3 skill selection is registry-driven by applies_when and declared inputs with deterministic capped output
• #3 Negative v3 input/applicability tests and legacy category tests pass

Implementation Plan

1. Inspect current Convex mutation payload construction and v3 selection
2. Add RED tests for no undefined payload patterns, negative v3 gating, and deterministic cap
3. Run focused tests and record RED failures
4. Implement minimal payload omission and registry-driven v3 selection
5. Run focused tests green plus pnpm test if fast
6. Self-review scope and leave task In Progress

Implementation Notes

RED: tsc passed, focused node --test .test-output/tests/audit-evidence.test.js .test-output/tests/audit-generation-action-source.test.js failed as expected on registry-order v3 cap and explicit undefined stage payload contract. GREEN: tsc passed; focused tests passed 26/26; full pnpm test passed 350/350. Self-review: no commits/staging, no changes to convex/usageEvents.ts, no ScreenshotOne missing-key behavior changes.