1.7 KiB
1.7 KiB
id, title, status, assignee, created_date, updated_date, labels, dependencies, priority, ordinal
| id | title | status | assignee | created_date | updated_date | labels | dependencies | priority | ordinal |
|---|---|---|---|---|---|---|---|---|---|
| TASK-38 | Add ScreenshotOne missing-key run warning | In Progress | 2026-06-06 21:41 | 2026-06-06 21:46 | high | 40000 |
Description
Emit a best-effort warning run event when an external audit needs screenshots but SCREENSHOTONE_API_KEY is not configured, while keeping audit classification and AI stages running.
Acceptance Criteria
- #1 needsScreenshots with missing SCREENSHOTONE_API_KEY writes a warning run event through appendRunEvent
- #2 warning logging is best-effort and cannot fail the audit run
- #3 needsScreenshots false does not emit the missing-key warning
Implementation Plan
- Inspect current ScreenshotOne skip path and source-contract style
- Add RED source-contract for warning event and best-effort guard
- Run focused test to capture RED
- Implement minimal runtime warning inside needsScreenshots missing-key branch
- Run focused tests green and broader tests if practical
- Self-review and report without staging or commits
Implementation Notes
RED verified: pnpm exec tsc -p tsconfig.test.json passed, then node --test .test-output/tests/external-audit-pipeline-source.test.js failed only on missing ScreenshotOne config warning message (actual index -1).
GREEN verified: focused node --test .test-output/tests/external-audit-pipeline-source.test.js passed 11/11 after implementation. Full pnpm test passed 357/357 with exit 0.