Compare commits

..

6 Commits

Author SHA1 Message Date
Matthias
807532a0a4 Merge branch 'codex-task-14-stalwart-smtp' 2026-06-05 21:12:55 +02:00
Matthias
2ac74dfde2 chore: mark task 14 done 2026-06-05 21:12:32 +02:00
Matthias
b2f7348ef0 Add SMTP send flow for approved outreach 2026-06-05 21:05:59 +02:00
Matthias
42a3ea64a5 Merge branch 'codex-task-13-review-workspace' 2026-06-05 17:04:49 +02:00
Matthias
5352893a47 fix: cache Convex JWT in server auth 2026-06-05 17:04:03 +02:00
Matthias
5a42c637c6 feat: build audit outreach review workspace 2026-06-05 16:47:22 +02:00
22 changed files with 3369 additions and 65 deletions

View File

@@ -1,10 +1,11 @@
import { DashboardPlaceholderPage } from "@/components/dashboard-placeholder-page"; import { OutreachReviewWorkspace } from "@/components/outreach/outreach-review-workspace";
export default function OutreachPage() { export default function OutreachPage() {
return ( return (
<DashboardPlaceholderPage <main className="px-4 py-5 sm:px-6 lg:px-8">
description="E-Mail-Entwürfe, Telefon-Skripte und manuelle Versandfreigaben folgen in TASK-13 und TASK-14." <div className="mx-auto flex w-full max-w-7xl flex-col gap-6">
title="Review" <OutreachReviewWorkspace />
/> </div>
</main>
); );
} }

View File

@@ -4,7 +4,7 @@ title: Build the audit and outreach review workspace
status: In Progress status: In Progress
assignee: [] assignee: []
created_date: '2026-06-03 19:14' created_date: '2026-06-03 19:14'
updated_date: '2026-06-05 12:13' updated_date: '2026-06-05 14:21'
labels: labels:
- mvp - mvp
- review - review
@@ -26,20 +26,23 @@ Create the internal review workspace where Matthias can inspect and edit the fin
## Acceptance Criteria ## Acceptance Criteria
<!-- AC:BEGIN --> <!-- AC:BEGIN -->
- [ ] #1 Review workspace shows lead details, contact sources, priority reason, contact strategy, audit summary, used skills, and raw/source detail toggles - [x] #1 Review workspace shows lead details, contact sources, priority reason, contact strategy, audit summary, used skills, and raw/source detail toggles
- [ ] #2 Audit content can be edited and manually approved before the public page shows customer-facing content - [x] #2 Audit content can be edited and manually approved before the public page shows customer-facing content
- [ ] #3 Email subject and body are editable and generated as exactly one recommended version by default - [x] #3 Email subject and body are editable and generated as exactly one recommended version by default
- [ ] #4 Phone script is available for Erst anrufen and Kontakt fehlt leads when a phone number exists - [x] #4 Phone script is available for Erst anrufen and Kontakt fehlt leads when a phone number exists
- [ ] #5 Freigabe offen state clearly separates Audit veröffentlichen from E-Mail freigeben und senden - [x] #5 Freigabe offen state clearly separates Audit veröffentlichen from E-Mail freigeben und senden
<!-- AC:END --> <!-- AC:END -->
## Implementation Plan ## Implementation Plan
<!-- SECTION:PLAN:BEGIN --> <!-- SECTION:PLAN:BEGIN -->
1. Wire PageSpeed completion into audit_generation queue 1. Orchestrator updates TASK-13 plan and coordinates only; no direct feature coding.
2. Verify handoff with regression tests 2. Worker A (gpt-5.5 medium) uses TDD to add Convex outreach review contracts: listReviewWorkspace, saveReviewDraft, approveEmailDraft.
3. Build review workspace UI and edit/approval flows 3. Worker B (gpt-5.5 medium) uses TDD to replace /dashboard/outreach placeholder with the review workspace UI using the new contracts.
4. Verify state transitions back into dashboard/funnel 4. Worker C (gpt-5.5 medium) uses TDD to separate Audit veröffentlichen from E-Mail freigeben and keep sending out of TASK-13.
5. Worker D (gpt-5.5 medium) uses TDD to cover phone-script visibility and funnel/review state regressions.
6. Spec and code-quality reviewer agents review each worker output before the next dependent slice proceeds.
7. Orchestrator runs final verification: pnpm test, pnpm exec tsc --noEmit, pnpm lint, pnpm build; then updates Backlog notes and checked ACs without marking Done.
<!-- SECTION:PLAN:END --> <!-- SECTION:PLAN:END -->
## Implementation Notes ## Implementation Notes
@@ -48,4 +51,8 @@ Create the internal review workspace where Matthias can inspect and edit the fin
Starting TASK-13 with the missing PageSpeed-to-audit-generation handoff so generated audit content exists for the review workspace. Starting TASK-13 with the missing PageSpeed-to-audit-generation handoff so generated audit content exists for the review workspace.
Implemented first TASK-13 prerequisite: PageSpeed completion now queues audit_generation for the same lead via internal.auditGeneration.queueLeadAuditGeneration. Queue failures are logged as warnings and do not fail the PageSpeed run. Verified with pnpm test (245/245), pnpm exec tsc --noEmit, pnpm lint (0 errors, existing generated warnings), and pnpm build using .env.local. Implemented first TASK-13 prerequisite: PageSpeed completion now queues audit_generation for the same lead via internal.auditGeneration.queueLeadAuditGeneration. Queue failures are logged as warnings and do not fail the PageSpeed run. Verified with pnpm test (245/245), pnpm exec tsc --noEmit, pnpm lint (0 errors, existing generated warnings), and pnpm build using .env.local.
2026-06-05: Expanded TASK-13 into subagent-driven, test-driven execution plan on branch codex-task-13-review-workspace. Orchestrator will not hand-code feature patches; workers use gpt-5.5 medium and RED/GREEN tests.
2026-06-05: Completed TASK-13 implementation subagent-driven and test-driven on branch codex-task-13-review-workspace. Worker A added authenticated Convex review workspace contracts, save/approve draft mutations, protected existing outreach create/list, audit ownership checks, sent-record protection, approval reset on regenerated copy, and combined review eligibility indexes. Worker B replaced /dashboard/outreach placeholder with the review workspace UI, editable audit/outreach drafts, raw/source toggles, used skills, phone-script gating, and save-before-approve/publish safeguards. Worker C fixed funnel regression so approved-but-unsent outreach remains in Freigabe offen. Reviews: backend spec approved, backend quality approved after fixes, UI spec approved, UI quality approved after fixes, funnel spec/quality approved, final TASK-13 spec approved. Verification passed: pnpm test (263/263), pnpm exec tsc --noEmit, pnpm lint (0 errors; existing BetterAuth generated warnings only), pnpm build with network escalation for Google Fonts.
<!-- SECTION:NOTES:END --> <!-- SECTION:NOTES:END -->

View File

@@ -1,9 +1,10 @@
--- ---
id: TASK-14 id: TASK-14
title: Send approved outreach through Stalwart SMTP title: Send approved outreach through Stalwart SMTP
status: To Do status: Done
assignee: [] assignee: []
created_date: '2026-06-03 19:14' created_date: '2026-06-03 19:14'
updated_date: '2026-06-05 19:06'
labels: labels:
- mvp - mvp
- email - email
@@ -24,19 +25,30 @@ Implement approved email sending through the self-hosted Stalwart mail server us
## Acceptance Criteria ## Acceptance Criteria
<!-- AC:BEGIN --> <!-- AC:BEGIN -->
- [ ] #1 Nodemailer is configured for Stalwart SMTP/SMTPS using environment or Convex secrets - [x] #1 Nodemailer is configured for Stalwart SMTP/SMTPS using environment or Convex secrets
- [ ] #2 E-Mail freigeben und senden sends only the currently approved/editable email draft to the visible recipient - [x] #2 E-Mail freigeben und senden sends only the currently approved/editable email draft to the visible recipient
- [ ] #3 A final send action shows recipient, subject, sender, and audit link before sending - [x] #3 A final send action shows recipient, subject, sender, and audit link before sending
- [ ] #4 Convex records sent timestamp, recipient, subject, audit link, SMTP result, and any error details - [x] #4 Convex records sent timestamp, recipient, subject, audit link, SMTP result, and any error details
- [ ] #5 SMTP failures keep the lead in a retryable review state and do not mark the lead as contacted - [x] #5 SMTP failures keep the lead in a retryable review state and do not mark the lead as contacted
<!-- AC:END --> <!-- AC:END -->
## Implementation Plan ## Implementation Plan
<!-- SECTION:PLAN:BEGIN --> <!-- SECTION:PLAN:BEGIN -->
1. Add SMTP transport configuration from secrets. 1. Analyse und TDD-Testergänzung
2. Add server-side send function that accepts only approved outreach IDs. 2. Implementierung backend Claims/Record + Guard-Fixes
3. Add final confirmation UI with recipient, subject, sender, and audit link. 3. Typing/Actions straffen + package lock
4. Store SMTP success/error outcomes and update lead/outreach status. 4. Typechecks lokal ausführen
5. Test success and failure paths with safe non-production recipients before real use.
<!-- SECTION:PLAN:END --> <!-- SECTION:PLAN:END -->
## Implementation Notes
<!-- SECTION:NOTES:BEGIN -->
Implemented TASK-14 via subagent-driven TDD. Verification passed: targeted outreach tests (27/27), pnpm test (278/278), pnpm exec tsc -p tsconfig.json --noEmit, pnpm lint (0 errors, 2 generated BetterAuth warnings), pnpm build (passed with network-enabled run for Google Fonts). Task remains In Progress until explicit user confirmation after manual SMTP testing.
<!-- SECTION:NOTES:END -->
## Final Summary
<!-- SECTION:FINAL_SUMMARY:BEGIN -->
Shipped approved outreach sending through Stalwart SMTP/SMTPS with Nodemailer, final confirmation UI, Convex send-attempt logging, retryable failure handling, and verification coverage. Verified with targeted outreach tests, full pnpm test, strict TypeScript, lint, and production build.
<!-- SECTION:FINAL_SUMMARY:END -->

View File

@@ -0,0 +1,98 @@
---
id: TASK-28
title: Diagnose dashboard initial-load retry loop
status: Done
assignee: []
created_date: '2026-06-05 13:46'
updated_date: '2026-06-05 15:03'
labels: []
dependencies: []
priority: high
ordinal: 30000
---
## Description
<!-- SECTION:DESCRIPTION:BEGIN -->
Find the root cause of the repeated dashboard requests on initial load, especially the repeated GET /dashboard/leads entries, and implement a targeted fix only after reproducing and tracing the loop.
<!-- SECTION:DESCRIPTION:END -->
## Acceptance Criteria
<!-- AC:BEGIN -->
- [x] #1 Root cause is identified with evidence from the relevant dashboard/auth/navigation code
- [x] #2 A minimal fix prevents repeated dashboard/leads requests on initial load
- [x] #3 Relevant tests or verification commands are run
<!-- AC:END -->
## Implementation Plan
<!-- SECTION:PLAN:BEGIN -->
1. Add a focused regression test proving server auth config enables Convex JWT cookie reuse.
2. Verify the test fails against the current auth-server configuration.
3. Enable the documented jwtCache option in convexBetterAuthNextJs with a scoped auth-error predicate.
4. Run the focused test, full test suite, and lint.
5. Record verification and leave TASK-28 open for user Firefox/Zen confirmation.
<!-- SECTION:PLAN:END -->
## Implementation Notes
<!-- SECTION:NOTES:BEGIN -->
Evidence gathered:
- User-provided log repeatedly shows successful GET /dashboard/leads during dashboard use.
- Existing Next dev log shows a hydration failure in components/dashboard-theme.tsx:88 inside DashboardThemeToggle during /dashboard rendering: server rendered Moon/aria-pressed=false while client rendered Sun/aria-pressed=true.
- Next local docs confirm client/server render differences during hydration cause the tree to be regenerated.
- Separate WIP issue observed: /dashboard/outreach imports a missing component, which can also produce repeated dev overlay errors, but the initial dashboard hydration error is the targeted root cause for this task.
Implemented targeted fix:
- DashboardThemeProvider now uses useSyncExternalStore with a stable server snapshot of light, preventing the server/client icon and aria-pressed mismatch on initial dashboard hydration.
- Added tests/dashboard-theme.test.ts to guard against reintroducing localStorage reads in the initial render path.
Verification:
- node --test .test-output/tests/dashboard-theme.test.js passes.
- pnpm test compiles and includes the new dashboard theme test as passing, but the full run still fails in existing TASK-13 outreach WIP test OutreachReviewWorkspace uses the review workspace API and required controls.
- pnpm lint no longer reports components/dashboard-theme.tsx; it still fails in existing components/outreach/outreach-review-workspace.tsx WIP.
Additional verification note:
- pnpm exec tsc --noEmit fails in existing components/outreach/outreach-review-workspace.tsx WIP with type mismatches and missing fields; this is separate from the dashboard theme hydration fix and was already part of unrelated TASK-13 worktree changes.
User retest on 2026-06-05 falsified the first hydration-only fix. New evidence: pnpm dev still logs repeated GET /dashboard/leads every roughly 300-400ms with 200 responses, with proxy.ts taking ~165-522ms each time, followed by one get-session and two convex token requests. Re-entering systematic debugging; no more fixes until request initiator is identified.
Added temporary development-only proxy instrumentation for /dashboard/leads request classification. It logs non-sensitive request headers: accept, rsc, next-router-prefetch, next-router-segment-prefetch, next-hmr-refresh, next-url, sec-fetch-mode, purpose, referer, state-tree presence, and user-agent. Remove after confirming requester.
Corrected root cause after user retest and header instrumentation:
- First hydration hypothesis was incomplete and did not stop the request fan-out.
- Development-only proxy header instrumentation showed real browser /dashboard/leads requests were same-origin CORS fetches with next-url set to the current dashboard route, not document reloads, HMR refreshes, or server redirect loops.
- Code search showed the repeated target originates from visible Next Link surfaces: dashboard sidebar nav plus many LeadFunnelCard action links that can share href /dashboard/leads. Next App Router prefetches visible links, and each protected prefetch crosses proxy.ts and isAuthenticated(), producing many 200 GET /dashboard/leads entries.
Implemented fix:
- Set prefetch={false} on DashboardSidebar nav links and LeadFunnelCard action links to keep click navigation but stop automatic protected-route prefetch fan-out.
- Removed temporary proxy/fetch diagnostics.
- Added tests/dashboard-prefetch.test.ts to lock this behavior.
Verification:
- pnpm exec tsc -p tsconfig.test.json passes.
- node --test .test-output/tests/dashboard-prefetch.test.js .test-output/tests/dashboard-theme.test.js passes.
- pnpm test passes 260/260.
- pnpm lint passes with existing generated/unused warnings only, no errors.
2026-06-05 Firefox/Zen HAR follow-up:
- User confirmed the reload loop reproduces in Firefox/Zen but not Chrome.
- HAR shows repeated top-level document navigations to /dashboard/audits, not XHR retries or Link prefetch.
- Requests already include better-auth.convex_jwt, but SSR responses embed fresh initialToken values and /api/auth/convex/token later sets better-auth.convex_jwt again.
- Local @convex-dev/better-auth source shows getToken() fetches /convex/token unless jwtCache.enabled is configured.
Next implementation hypothesis: enable jwtCache so server getToken() reuses a valid Convex JWT cookie instead of minting a new token during each root layout render.
Implemented Firefox/Zen token-churn fix:
- Added jwtCache.enabled to lib/auth-server.ts for convexBetterAuthNextJs, matching the Convex Better Auth Next.js server utilities docs.
- Added a scoped isConvexAuthError predicate so recognized application auth failures still surface, while stale cached-token failures can trigger the library refresh path.
- Added tests/auth-server-jwt-cache.test.ts to guard the server auth cache configuration.
Verification after fix:
- pnpm exec tsc -p tsconfig.test.json passes.
- node --test .test-output/tests/auth-server-jwt-cache.test.js passes after failing before the implementation.
- pnpm test passes 265/265.
- pnpm lint passes with two existing generated-file warnings and no errors.
Manual confirmation still needed in Firefox/Zen before closing TASK-28 as Done.
<!-- SECTION:NOTES:END -->
## Final Summary
<!-- SECTION:FINAL_SUMMARY:BEGIN -->
Firefox/Zen reload loop fixed by enabling Convex Better Auth JWT caching in Next.js server auth utilities; regression test added and full tests/lint passed. User confirmed dashboard now loads reliably without loops.
<!-- SECTION:FINAL_SUMMARY:END -->

View File

@@ -55,6 +55,7 @@ export function DashboardSidebar() {
)} )}
href={item.href} href={item.href}
key={item.href} key={item.href}
prefetch={false}
> >
<Icon className="size-4" /> <Icon className="size-4" />
<span>{item.label}</span> <span>{item.label}</span>

View File

@@ -6,7 +6,7 @@ import {
type ReactNode, type ReactNode,
useContext, useContext,
useMemo, useMemo,
useState, useSyncExternalStore,
} from "react"; } from "react";
import { Button } from "@/components/ui/button"; import { Button } from "@/components/ui/button";
@@ -20,34 +20,49 @@ type DashboardThemeContextValue = {
}; };
const storageKey = "webdev-dashboard-theme"; const storageKey = "webdev-dashboard-theme";
const themeChangeEvent = "webdev-dashboard-theme-change";
const DashboardThemeContext = const DashboardThemeContext =
createContext<DashboardThemeContextValue | null>(null); createContext<DashboardThemeContextValue | null>(null);
export function DashboardThemeProvider({ children }: { children: ReactNode }) { function isDashboardTheme(value: string | null): value is DashboardTheme {
const [theme, setTheme] = useState<DashboardTheme>(() => { return value === "dark" || value === "light";
if (typeof window === "undefined") {
return "light";
} }
function getStoredDashboardTheme(): DashboardTheme {
const storedTheme = window.localStorage.getItem(storageKey); const storedTheme = window.localStorage.getItem(storageKey);
if (storedTheme === "dark" || storedTheme === "light") { return isDashboardTheme(storedTheme) ? storedTheme : "light";
return storedTheme;
} }
function getServerDashboardTheme(): DashboardTheme {
return "light"; return "light";
}); }
function subscribeToDashboardTheme(onStoreChange: () => void) {
window.addEventListener("storage", onStoreChange);
window.addEventListener(themeChangeEvent, onStoreChange);
return () => {
window.removeEventListener("storage", onStoreChange);
window.removeEventListener(themeChangeEvent, onStoreChange);
};
}
export function DashboardThemeProvider({ children }: { children: ReactNode }) {
const theme = useSyncExternalStore(
subscribeToDashboardTheme,
getStoredDashboardTheme,
getServerDashboardTheme,
);
const value = useMemo<DashboardThemeContextValue>( const value = useMemo<DashboardThemeContextValue>(
() => ({ () => ({
theme, theme,
toggleTheme: () => { toggleTheme: () => {
setTheme((currentTheme) => { const nextTheme = theme === "dark" ? "light" : "dark";
const nextTheme = currentTheme === "dark" ? "light" : "dark";
window.localStorage.setItem(storageKey, nextTheme); window.localStorage.setItem(storageKey, nextTheme);
return nextTheme; window.dispatchEvent(new Event(themeChangeEvent));
});
}, },
}), }),
[theme], [theme],

View File

@@ -170,6 +170,7 @@ function LeadFunnelCardView({ card }: { card: LeadFunnelCard }) {
<Link <Link
className="mt-3 inline-flex min-h-8 items-center gap-1 rounded-md text-sm font-medium text-primary outline-none hover:underline focus-visible:ring-3 focus-visible:ring-ring/50" className="mt-3 inline-flex min-h-8 items-center gap-1 rounded-md text-sm font-medium text-primary outline-none hover:underline focus-visible:ring-3 focus-visible:ring-ring/50"
href={stageActionHref[card.stageId]} href={stageActionHref[card.stageId]}
prefetch={false}
> >
{card.nextAction} {card.nextAction}
<ArrowRight className="size-4" /> <ArrowRight className="size-4" />

View File

@@ -0,0 +1,858 @@
"use client";
import { useMemo, useState } from "react";
import { useAction, useMutation, useQuery } from "convex/react";
import type { FunctionReturnType } from "convex/server";
import { ChevronDown, ChevronRight, ExternalLink, MailCheck, Save } from "lucide-react";
import Link from "next/link";
import { api } from "@/convex/_generated/api";
import { Badge } from "@/components/ui/badge";
import { Button } from "@/components/ui/button";
import { Card, CardContent, CardHeader, CardTitle } from "@/components/ui/card";
import {
Dialog,
DialogCloseButton,
DialogContent,
DialogDescription,
DialogHeader,
DialogTitle,
} from "@/components/ui/dialog";
import { Input } from "@/components/ui/input";
import { Skeleton } from "@/components/ui/skeleton";
import { cn } from "@/lib/utils";
type ReviewWorkspaceListResult = FunctionReturnType<
typeof api.outreach.listReviewWorkspace
>;
type ReviewWorkspaceItem = NonNullable<ReviewWorkspaceListResult>[number];
type UsedSkill = ReviewWorkspaceItem["usedSkills"][number];
type DraftState = {
auditBody: string;
auditSummary: string;
emailBody: string;
emailSubject: string;
followUpDraft: string;
phoneScript: string;
};
type PendingEmailConfirmation = {
id: NonNullable<ReviewWorkspaceItem["latestOutreach"]>["_id"];
recipient: string;
subject: string;
sender: string;
auditSlug: string | null;
};
const emptyDraft: DraftState = {
auditBody: "",
auditSummary: "",
emailBody: "",
emailSubject: "",
followUpDraft: "",
phoneScript: "",
};
const textAreaClassName =
"min-h-24 w-full rounded-md border border-input bg-background px-2.5 py-2 text-sm text-foreground placeholder:text-muted-foreground focus-visible:border-ring focus-visible:ring-3 focus-visible:ring-ring/50 focus-visible:outline-none disabled:cursor-not-allowed disabled:opacity-50";
function getDraft(record: ReviewWorkspaceItem): DraftState {
const outreach = record.latestOutreach;
return {
auditBody: record.audit?.publicBody ?? "",
auditSummary: record.audit?.publicSummary ?? "",
emailBody: outreach?.emailBody ?? "",
emailSubject: outreach?.emailSubject ?? "",
followUpDraft: outreach?.followUpDraft ?? "",
phoneScript: outreach?.phoneScript ?? "",
};
}
function compactText(value?: string | null, fallback = "Offen") {
const trimmed = value?.trim();
return trimmed ? trimmed : fallback;
}
function toStringIfText(value: unknown) {
return typeof value === "string" ? value.trim() : "";
}
function toNullableString(value: unknown) {
const text = toStringIfText(value);
return text.length > 0 ? text : null;
}
function asRecord(value: unknown) {
return (typeof value === "object" && value !== null ? (value as Record<string, unknown>) : {});
}
function extractRecordValue(record: Record<string, unknown>, candidates: string[]) {
for (const candidate of candidates) {
const text = toStringIfText(record[candidate]);
if (text) {
return text;
}
}
return "";
}
function formatStrategy(strategy?: string | null) {
const labels: Record<string, string> = {
call_first: "Erst anrufen",
defer: "Zurückstellen",
do_not_contact: "Nicht kontaktieren",
email_first: "Erst E-Mail",
};
return strategy ? labels[strategy] ?? strategy : "Strategie offen";
}
function formatRaw(value: unknown) {
if (value === undefined || value === null) {
return "Keine Rohdaten vorhanden.";
}
return JSON.stringify(value, null, 2);
}
function skillLabel(skill: UsedSkill) {
const name = compactText(skill?.name, "Skill");
return skill.category ? `${name} · ${skill.category}` : name;
}
function DetailToggle({
isOpen,
label,
onClick,
}: {
isOpen: boolean;
label: string;
onClick: () => void;
}) {
const Icon = isOpen ? ChevronDown : ChevronRight;
return (
<Button
aria-expanded={isOpen}
onClick={onClick}
size="sm"
type="button"
variant="outline"
>
<Icon className="size-3.5" />
{label}
</Button>
);
}
function FieldPair({ label, value }: { label: string; value?: string | null }) {
return (
<div className="min-w-0">
<dt className="text-xs font-medium text-muted-foreground">{label}</dt>
<dd className="mt-1 break-words text-sm">{compactText(value)}</dd>
</div>
);
}
function WorkspaceLoading() {
return (
<section className="space-y-4">
<header className="space-y-2">
<p className="text-sm text-muted-foreground">Interne Outreach-Prüfung</p>
<h1 className="text-2xl font-semibold tracking-normal">Review Workspace</h1>
</header>
<div className="space-y-3">
{Array.from({ length: 3 }, (_, index) => (
<Skeleton className="h-56 rounded-lg" key={index} />
))}
</div>
</section>
);
}
export function OutreachReviewWorkspace() {
const records = useQuery(api.outreach.listReviewWorkspace, { limit: 100 });
const saveReviewDraft = useMutation(api.outreach.saveReviewDraft);
const approveEmailDraft = useMutation(api.outreach.approveEmailDraft);
const savePublicAuditContent = useMutation(api.audits.savePublicAuditContent);
const publishPublicAudit = useMutation(api.audits.publishPublicAudit);
const sendApprovedEmail = useAction(api.outreachSendAction.sendApprovedEmail);
const [drafts, setDrafts] = useState<Record<string, DraftState>>({});
const [openSources, setOpenSources] = useState<Record<string, boolean>>({});
const [openRaw, setOpenRaw] = useState<Record<string, boolean>>({});
const [busyAction, setBusyAction] = useState<string | null>(null);
const [notice, setNotice] = useState<string | null>(null);
const [pendingEmailConfirmation, setPendingEmailConfirmation] =
useState<PendingEmailConfirmation | null>(null);
const rows = useMemo<ReviewWorkspaceItem[]>(() => records ?? [], [records]);
if (records === undefined) {
return <WorkspaceLoading />;
}
if (rows.length === 0) {
return (
<section className="space-y-4">
<header className="space-y-2">
<p className="text-sm text-muted-foreground">Interne Outreach-Prüfung</p>
<h1 className="text-2xl font-semibold tracking-normal">Review Workspace</h1>
</header>
<Card>
<CardContent className="p-4">
<p className="text-sm font-medium">Keine offenen Reviews</p>
<p className="mt-1 text-sm text-muted-foreground">
Sobald Audit- und Outreach-Entwürfe bereitstehen, erscheinen sie hier.
</p>
</CardContent>
</Card>
</section>
);
}
const updateDraft = (
id: string,
field: keyof DraftState,
value: string,
) => {
const record = rows.find((row) => row.id === id);
setDrafts((current) => ({
...current,
[id]: {
...(current[id] ?? (record ? getDraft(record) : emptyDraft)),
[field]: value,
},
}));
};
const saveAudit = async (record: ReviewWorkspaceItem) => {
const auditId = record.audit?._id;
if (!auditId) {
setNotice("Audit kann ohne Audit-ID nicht gespeichert werden.");
return;
}
setBusyAction(`${record.id}:audit-save`);
setNotice(null);
try {
const draft = drafts[record.id] ?? getDraft(record);
await savePublicAuditContent({
id: auditId,
publicBody: draft.auditBody,
publicSummary: draft.auditSummary,
});
setNotice("Audit-Änderungen gespeichert.");
} catch {
setNotice("Audit-Änderungen konnten nicht gespeichert werden.");
} finally {
setBusyAction(null);
}
};
const publishAudit = async (record: ReviewWorkspaceItem) => {
const auditId = record.audit?._id;
if (!auditId) {
setNotice("Audit kann ohne Audit-ID nicht veröffentlicht werden.");
return;
}
setBusyAction(`${record.id}:audit-publish`);
setNotice(null);
try {
const draft = drafts[record.id] ?? getDraft(record);
await savePublicAuditContent({
id: auditId,
publicBody: draft.auditBody,
publicSummary: draft.auditSummary,
});
await publishPublicAudit({ id: auditId });
setNotice("Audit veröffentlicht.");
} catch {
setNotice("Audit konnte nicht veröffentlicht werden.");
} finally {
setBusyAction(null);
}
};
const saveOutreach = async (record: ReviewWorkspaceItem) => {
const outreach = record.latestOutreach;
if (!outreach) {
setNotice("Outreach-Entwurf kann ohne Outreach-ID nicht gespeichert werden.");
return;
}
if (outreach.sendStatus === "queued") {
setNotice(
"Aufgrund des laufenden Sendevorgangs kann der Outreach-Entwurf nicht gespeichert werden.",
);
return;
}
const draft = drafts[record.id] ?? getDraft(record);
const strategy = outreach.strategy;
const hasCallablePhone =
Boolean(record.lead?.phone) &&
(strategy === "call_first" ||
record.lead?.contactStatus === "missing_contact");
setBusyAction(`${record.id}:outreach-save`);
setNotice(null);
try {
await saveReviewDraft({
id: outreach._id,
strategy,
emailBody: draft.emailBody,
emailSubject: draft.emailSubject,
followUpDraft: draft.followUpDraft,
...(hasCallablePhone ? { phoneScript: draft.phoneScript } : {}),
});
setNotice("Outreach-Entwurf gespeichert.");
} catch {
setNotice("Outreach-Entwurf konnte nicht gespeichert werden.");
} finally {
setBusyAction(null);
}
};
const closeEmailConfirmation = () => {
setPendingEmailConfirmation(null);
};
const sendApprovedEmailFromConfirmation = async () => {
const confirmation = pendingEmailConfirmation;
if (!confirmation) {
return;
}
const isQueuedSend = rows.some(
(row: ReviewWorkspaceItem) =>
row.latestOutreach?._id === confirmation.id &&
row.latestOutreach?.sendStatus === "queued",
);
if (isQueuedSend) {
setNotice(
"Aufgrund des laufenden Sendevorgangs kann der Versand nicht erneut gestartet werden.",
);
return;
}
setBusyAction(`${confirmation.id}:email-send`);
setNotice(null);
try {
await sendApprovedEmail({ id: confirmation.id });
setNotice("E-Mail gesendet.");
setPendingEmailConfirmation(null);
} catch {
setNotice(
"E-Mail konnte nicht gesendet werden. Bitte erneut versuchen.",
);
} finally {
setBusyAction(null);
}
};
const approveEmail = async (record: ReviewWorkspaceItem) => {
const outreach = record.latestOutreach;
const lead = record.lead;
const audit = record.audit;
if (!outreach) {
setNotice("E-Mail kann ohne Outreach-ID nicht freigegeben werden.");
return;
}
if (outreach.sendStatus === "queued") {
setNotice(
"Aufgrund des laufenden Sendevorgangs kann die E-Mail nicht freigegeben werden.",
);
return;
}
const draft = drafts[record.id] ?? getDraft(record);
const strategy = outreach.strategy;
const hasCallablePhone =
Boolean(record.lead?.phone) &&
(strategy === "call_first" ||
record.lead?.contactStatus === "missing_contact");
setBusyAction(`${record.id}:email-approval`);
setNotice(null);
try {
await saveReviewDraft({
id: outreach._id,
strategy,
emailBody: draft.emailBody,
emailSubject: draft.emailSubject,
followUpDraft: draft.followUpDraft,
...(hasCallablePhone ? { phoneScript: draft.phoneScript } : {}),
});
const approvalResult = await approveEmailDraft({ id: outreach._id });
const approvalData = asRecord(approvalResult);
const recipient =
extractRecordValue(approvalData, ["recipient", "email", "emailAddress"]) ||
lead?.email ||
"Offen";
const subject =
extractRecordValue(approvalData, [
"emailSubject",
"subject",
"title",
]) || draft.emailSubject;
const sender = toNullableString(approvalData.sender);
if (!sender) {
throw new Error("SMTP-Absender in der Freigabeantwort fehlt.");
}
const auditSlug =
extractRecordValue(approvalData, ["auditSlug", "slug", "audit"]) ||
audit?.slug ||
null;
setPendingEmailConfirmation({
id: outreach._id,
recipient,
subject,
sender,
auditSlug,
});
setNotice("E-Mail freigegeben.");
} catch {
setNotice("E-Mail konnte nicht freigegeben werden.");
} finally {
setBusyAction(null);
}
};
const confirmationAuditLink = pendingEmailConfirmation?.auditSlug
? `/audit/${pendingEmailConfirmation.auditSlug}`
: null;
const pendingQueuedOutreachId = pendingEmailConfirmation?.id;
const isQueuedSendForConfirmation = rows.some(
(row: ReviewWorkspaceItem) =>
row.latestOutreach?._id === pendingQueuedOutreachId &&
row.latestOutreach?.sendStatus === "queued",
);
return (
<section className="space-y-4">
<header className="space-y-2">
<p className="text-sm text-muted-foreground">Interne Outreach-Prüfung</p>
<h1 className="text-2xl font-semibold tracking-normal">Review Workspace</h1>
<p className="max-w-3xl text-sm text-muted-foreground">
Audits, E-Mail-Empfehlung und Telefonnotizen prüfen, bevor etwas öffentlich
wird oder eine Freigabe erhält.
</p>
</header>
{notice ? (
<p className="rounded-md border bg-muted/30 px-3 py-2 text-sm">{notice}</p>
) : null}
<Dialog
open={Boolean(pendingEmailConfirmation)}
onOpenChange={(open) => {
if (!open) {
closeEmailConfirmation();
}
}}
>
{pendingEmailConfirmation ? (
<DialogContent className="space-y-4">
<DialogHeader>
<DialogTitle>E-Mail-Versand bestätigen</DialogTitle>
<DialogDescription>
Bitte prüfen Sie vor dem Senden die Finaldaten.
</DialogDescription>
<DialogCloseButton />
</DialogHeader>
<div className="space-y-3">
<div className="min-w-0">
<label className="text-xs font-medium text-muted-foreground">
Empfänger
</label>
<p className="break-words text-sm">{pendingEmailConfirmation.recipient}</p>
</div>
<div className="min-w-0">
<label className="text-xs font-medium text-muted-foreground">
Betreff
</label>
<p className="break-words text-sm">{pendingEmailConfirmation.subject}</p>
</div>
<div className="min-w-0">
<label className="text-xs font-medium text-muted-foreground">
Absender
</label>
<p className="text-sm">
{pendingEmailConfirmation.sender}
</p>
</div>
<div className="min-w-0">
<label className="text-xs font-medium text-muted-foreground">
Audit-Link
</label>
{confirmationAuditLink ? (
<Link
className="inline-flex items-center gap-1 break-all text-sm text-blue-600 hover:underline"
href={confirmationAuditLink}
>
<ExternalLink className="size-3.5" />
{confirmationAuditLink}
</Link>
) : (
<p className="text-sm text-muted-foreground">Nicht verfügbar.</p>
)}
</div>
</div>
<div className="flex flex-wrap gap-2">
<Button
disabled={
busyAction === `${pendingEmailConfirmation.id}:email-send` ||
isQueuedSendForConfirmation
}
onClick={sendApprovedEmailFromConfirmation}
size="sm"
type="button"
>
Senden
</Button>
<Button onClick={closeEmailConfirmation} size="sm" type="button" variant="outline">
Abbrechen
</Button>
</div>
</DialogContent>
) : null}
</Dialog>
<div className="space-y-3">
{rows.map((record) => {
const draft = drafts[record.id] ?? getDraft(record);
const lead = record.lead;
const audit = record.audit;
const outreach = record.latestOutreach;
const isQueuedSend = outreach?.sendStatus === "queued";
const strategy = outreach?.strategy;
const contactSources = [
lead.email ? `E-Mail: ${lead.email}` : null,
lead.phone ? `Telefon: ${lead.phone}` : null,
...record.sourceSummaries.emailCandidates.map(
(candidate) =>
`${candidate.email} · ${candidate.emailSource}${
candidate.accepted ? " · akzeptiert" : ""
}`,
),
].filter((source): source is string => Boolean(source));
const skills = record.usedSkills;
const hasCallablePhone =
Boolean(lead?.phone) &&
(strategy === "call_first" ||
lead?.contactStatus === "missing_contact");
const publicAuditHref = audit?.slug ? `/audit/${audit.slug}` : null;
return (
<Card className="overflow-hidden" key={record.id}>
<CardHeader className="gap-3 border-b bg-muted/20 p-4">
<div className="flex flex-col gap-3 lg:flex-row lg:items-start lg:justify-between">
<div className="min-w-0 space-y-1">
<CardTitle className="break-words text-lg">
{compactText(lead?.companyName, "Unbenannter Lead")}
</CardTitle>
<p className="break-all text-sm text-muted-foreground">
{compactText(
lead?.websiteDomain ?? lead?.websiteUrl,
"Keine Domain",
)}
</p>
</div>
<div className="flex flex-wrap gap-2">
<Badge variant="secondary">{formatStrategy(strategy)}</Badge>
<Badge variant="outline">
{compactText(lead?.contactStatus, "Kontaktstatus offen")}
</Badge>
<Badge variant="outline">
{compactText(audit?.status, "Auditstatus offen")}
</Badge>
</div>
</div>
</CardHeader>
<CardContent className="space-y-5 p-4">
<section className="grid gap-4 lg:grid-cols-[minmax(0,0.8fr)_minmax(0,1.2fr)]">
<div className="space-y-3">
<h2 className="text-sm font-semibold">Lead-Details</h2>
<dl className="grid gap-3 sm:grid-cols-2">
<FieldPair label="Nische" value={lead?.niche} />
<FieldPair
label="Ort"
value={[lead?.postalCode, lead?.city].filter(Boolean).join(" ")}
/>
<FieldPair label="Ansprechperson" value={lead?.contactPerson} />
<FieldPair label="E-Mail" value={lead?.email} />
<FieldPair label="Telefon" value={lead?.phone} />
<FieldPair label="Quelle" value={lead?.googleMapsUrl} />
</dl>
<div className="space-y-1">
<h3 className="text-xs font-medium text-muted-foreground">
Prioritätsgrund
</h3>
<p className="break-words text-sm">
{compactText(lead?.priorityReason)}
</p>
</div>
<div className="space-y-1">
<h3 className="text-xs font-medium text-muted-foreground">
Kontaktstrategie
</h3>
<p className="text-sm">{formatStrategy(strategy)}</p>
</div>
</div>
<div className="space-y-3">
<div className="flex flex-wrap items-center justify-between gap-2">
<h2 className="text-sm font-semibold">Audit-Zusammenfassung</h2>
{publicAuditHref ? (
<Button asChild size="sm" type="button" variant="outline">
<Link href={publicAuditHref}>
<ExternalLink className="size-3.5" />
Public-Audit
</Link>
</Button>
) : (
<span className="text-sm text-muted-foreground">
Public-Audit ohne Slug
</span>
)}
</div>
<label className="block space-y-1">
<span className="text-xs font-medium text-muted-foreground">
Public-Audit Slug
</span>
<span className="block break-all text-sm">
{compactText(audit?.slug, "Slug offen")}
</span>
</label>
<label className="block space-y-1">
<span className="text-xs font-medium text-muted-foreground">
Audit Kurzfassung
</span>
<textarea
className={cn(textAreaClassName, "min-h-20")}
onChange={(event) =>
updateDraft(record.id, "auditSummary", event.target.value)
}
value={draft.auditSummary}
/>
</label>
<label className="block space-y-1">
<span className="text-xs font-medium text-muted-foreground">
Audit öffentlicher Text
</span>
<textarea
className={cn(textAreaClassName, "min-h-28")}
onChange={(event) =>
updateDraft(record.id, "auditBody", event.target.value)
}
value={draft.auditBody}
/>
</label>
<div className="flex flex-wrap gap-2">
<Button
disabled={busyAction === `${record.id}:audit-save`}
onClick={() => saveAudit(record)}
size="sm"
type="button"
variant="outline"
>
<Save className="size-3.5" />
Änderungen speichern
</Button>
<Button
disabled={busyAction === `${record.id}:audit-publish`}
onClick={() => publishAudit(record)}
size="sm"
type="button"
>
Audit veröffentlichen
</Button>
</div>
</div>
</section>
<section className="grid gap-4 lg:grid-cols-[minmax(0,1fr)_minmax(0,1fr)]">
<div className="space-y-3">
<h2 className="text-sm font-semibold">Empfohlene E-Mail</h2>
<label className="block space-y-1">
<span className="text-xs font-medium text-muted-foreground">
E-Mail-Betreff
</span>
<Input
aria-label="E-Mail-Betreff"
onChange={(event) =>
updateDraft(record.id, "emailSubject", event.target.value)
}
value={draft.emailSubject}
/>
</label>
<label className="block space-y-1">
<span className="text-xs font-medium text-muted-foreground">
E-Mail-Text
</span>
<textarea
aria-label="E-Mail-Text"
className={cn(textAreaClassName, "min-h-40")}
onChange={(event) =>
updateDraft(record.id, "emailBody", event.target.value)
}
value={draft.emailBody}
/>
</label>
<div className="flex flex-wrap gap-2">
<Button
disabled={
busyAction === `${record.id}:outreach-save` || isQueuedSend
}
onClick={() => saveOutreach(record)}
size="sm"
type="button"
variant="outline"
>
<Save className="size-3.5" />
Änderungen speichern
</Button>
<Button
disabled={
busyAction === `${record.id}:email-approval` || isQueuedSend
}
onClick={() => approveEmail(record)}
size="sm"
type="button"
>
<MailCheck className="size-3.5" />
E-Mail freigeben und senden
</Button>
</div>
</div>
<div className="space-y-3">
<h2 className="text-sm font-semibold">Telefon & Follow-up</h2>
{hasCallablePhone ? (
<label className="block space-y-1">
<span className="text-xs font-medium text-muted-foreground">
Telefon-Skript
</span>
<textarea
className={cn(textAreaClassName, "min-h-32")}
onChange={(event) =>
updateDraft(record.id, "phoneScript", event.target.value)
}
value={draft.phoneScript}
/>
</label>
) : (
<p className="rounded-md border bg-muted/20 px-3 py-2 text-sm text-muted-foreground">
Kein Telefon-Skript erforderlich.
</p>
)}
<label className="block space-y-1">
<span className="text-xs font-medium text-muted-foreground">
Follow-up-Draft
</span>
<textarea
className={cn(textAreaClassName, "min-h-28")}
onChange={(event) =>
updateDraft(record.id, "followUpDraft", event.target.value)
}
value={draft.followUpDraft}
/>
</label>
</div>
</section>
<section className="space-y-3">
<div className="flex flex-wrap gap-2">
<DetailToggle
isOpen={Boolean(openSources[record.id])}
label="Quellen anzeigen"
onClick={() =>
setOpenSources((current) => ({
...current,
[record.id]: !current[record.id],
}))
}
/>
<DetailToggle
isOpen={Boolean(openRaw[record.id])}
label="Raw anzeigen"
onClick={() =>
setOpenRaw((current) => ({
...current,
[record.id]: !current[record.id],
}))
}
/>
</div>
{openSources[record.id] ? (
<div className="grid gap-3 rounded-md border bg-muted/20 p-3 lg:grid-cols-2">
<div className="min-w-0 space-y-2">
<h2 className="text-sm font-semibold">Kontaktquellen</h2>
{contactSources.length > 0 ? (
<ul className="space-y-1 text-sm">
{contactSources.map((source, index) => (
<li className="break-words" key={`${source}-${index}`}>
{source}
</li>
))}
</ul>
) : (
<p className="text-sm text-muted-foreground">
Keine Kontaktquellen hinterlegt.
</p>
)}
</div>
<div className="min-w-0 space-y-2">
<h2 className="text-sm font-semibold">Verwendete Skills</h2>
{skills.length > 0 ? (
<div className="flex flex-wrap gap-2">
{skills.map((skill, index) => (
<Badge key={index} variant="outline">
{skillLabel(skill)}
</Badge>
))}
</div>
) : (
<p className="text-sm text-muted-foreground">
Keine Skills dokumentiert.
</p>
)}
</div>
</div>
) : null}
{openRaw[record.id] ? (
<pre className="max-h-72 overflow-auto rounded-md border bg-muted/20 p-3 text-xs whitespace-pre-wrap">
{formatRaw({
audit,
auditGenerations: record.auditGenerations,
latestOutreach: outreach,
lead,
skillSummaries: record.skillSummaries,
sourceSummaries: record.sourceSummaries,
})}
</pre>
) : null}
</section>
</CardContent>
</Card>
);
})}
</div>
</section>
);
}

View File

@@ -19,6 +19,7 @@ import type * as http from "../http.js";
import type * as leadDiscovery from "../leadDiscovery.js"; import type * as leadDiscovery from "../leadDiscovery.js";
import type * as leads from "../leads.js"; import type * as leads from "../leads.js";
import type * as outreach from "../outreach.js"; import type * as outreach from "../outreach.js";
import type * as outreachSendAction from "../outreachSendAction.js";
import type * as pageSpeed from "../pageSpeed.js"; import type * as pageSpeed from "../pageSpeed.js";
import type * as pageSpeedAction from "../pageSpeedAction.js"; import type * as pageSpeedAction from "../pageSpeedAction.js";
import type * as runs from "../runs.js"; import type * as runs from "../runs.js";
@@ -45,6 +46,7 @@ declare const fullApi: ApiFromModules<{
leadDiscovery: typeof leadDiscovery; leadDiscovery: typeof leadDiscovery;
leads: typeof leads; leads: typeof leads;
outreach: typeof outreach; outreach: typeof outreach;
outreachSendAction: typeof outreachSendAction;
pageSpeed: typeof pageSpeed; pageSpeed: typeof pageSpeed;
pageSpeedAction: typeof pageSpeedAction; pageSpeedAction: typeof pageSpeedAction;
runs: typeof runs; runs: typeof runs;

View File

@@ -2,6 +2,8 @@ import { v } from "convex/values";
import { normalizeListLimit } from "./domain"; import { normalizeListLimit } from "./domain";
import { internalMutation, mutation, query } from "./_generated/server"; import { internalMutation, mutation, query } from "./_generated/server";
import type { Doc, Id } from "./_generated/dataModel";
import type { MutationCtx, QueryCtx } from "./_generated/server";
const strategy = v.union( const strategy = v.union(
v.literal("call_first"), v.literal("call_first"),
@@ -10,6 +12,231 @@ const strategy = v.union(
v.literal("do_not_contact"), v.literal("do_not_contact"),
); );
const REVIEW_JOIN_LIMIT = 4;
const requireOperator = async (ctx: QueryCtx | MutationCtx) => {
const identity = await ctx.auth.getUserIdentity();
if (!identity) {
throw new Error("Nicht autorisiert.");
}
return identity;
};
const latestOutreachForLead = async (
ctx: QueryCtx,
leadId: Id<"leads">,
) => {
const rows = await ctx.db
.query("outreachRecords")
.withIndex("by_leadId", (q) => q.eq("leadId", leadId))
.order("desc")
.take(1);
return rows[0] ?? null;
};
const latestAuditForLead = async (ctx: QueryCtx, leadId: Id<"leads">) => {
const rows = await ctx.db
.query("audits")
.withIndex("by_leadId", (q) => q.eq("leadId", leadId))
.order("desc")
.take(1);
return rows[0] ?? null;
};
const loadReviewRow = async (
ctx: QueryCtx,
lead: Doc<"leads">,
reviewOutreach: Doc<"outreachRecords"> | null,
) => {
const latestOutreach = reviewOutreach ?? await latestOutreachForLead(ctx, lead._id);
const audit = latestOutreach?.auditId
? await ctx.db.get(latestOutreach.auditId)
: await latestAuditForLead(ctx, lead._id);
const auditGenerations = audit
? await ctx.db
.query("auditGenerations")
.withIndex("by_auditId", (q) => q.eq("auditId", audit._id))
.order("desc")
.take(REVIEW_JOIN_LIMIT)
: await ctx.db
.query("auditGenerations")
.withIndex("by_leadId", (q) => q.eq("leadId", lead._id))
.order("desc")
.take(REVIEW_JOIN_LIMIT);
const pageSpeedResults = audit
? await ctx.db
.query("pageSpeedResults")
.withIndex("by_auditId", (q) => q.eq("auditId", audit._id))
.order("desc")
.take(REVIEW_JOIN_LIMIT)
: await ctx.db
.query("pageSpeedResults")
.withIndex("by_leadId", (q) => q.eq("leadId", lead._id))
.order("desc")
.take(REVIEW_JOIN_LIMIT);
const crawlPages = await ctx.db
.query("websiteCrawlPages")
.withIndex("by_leadId_and_createdAt", (q) => q.eq("leadId", lead._id))
.order("desc")
.take(REVIEW_JOIN_LIMIT);
const emailCandidates = await ctx.db
.query("websiteEmailCandidates")
.withIndex("by_leadId", (q) => q.eq("leadId", lead._id))
.order("desc")
.take(REVIEW_JOIN_LIMIT);
return {
id: lead._id,
lead: {
id: lead._id,
companyName: lead.companyName,
niche: lead.niche ?? null,
address: lead.address ?? null,
city: lead.city ?? null,
postalCode: lead.postalCode ?? null,
websiteUrl: lead.websiteUrl ?? null,
websiteDomain: lead.websiteDomain ?? null,
email: lead.email ?? null,
normalizedEmail: lead.normalizedEmail ?? null,
phone: lead.phone ?? null,
normalizedPhone: lead.normalizedPhone ?? null,
contactPerson: lead.contactPerson ?? null,
priority: lead.priority,
priorityReason: lead.priorityReason ?? null,
contactStatus: lead.contactStatus,
contactStatusReason: lead.contactStatusReason ?? null,
duplicateStatus: lead.duplicateStatus,
duplicateReason: lead.duplicateReason ?? null,
blacklistStatus: lead.blacklistStatus,
blacklistReason: lead.blacklistReason ?? null,
notes: lead.notes ?? null,
googleMapsUrl: lead.googleMapsUrl ?? null,
googleRating: lead.googleRating ?? null,
googleUserRatingCount: lead.googleUserRatingCount ?? null,
updatedAt: lead.updatedAt,
},
latestOutreach: latestOutreach,
audit: audit,
auditGenerations: auditGenerations.map((generation) => ({
id: generation._id,
stage: generation.stage,
status: generation.status,
modelProfile: generation.modelProfile,
modelId: generation.modelId,
errorSummary: generation.errorSummary ?? null,
finishReason: generation.finishReason ?? null,
parsedJson: generation.parsedJson ?? null,
createdAt: generation.createdAt,
updatedAt: generation.updatedAt,
})),
usedSkills: audit?.usedSkills ?? [],
skillSummaries: audit?.skillSummaries ?? [],
sourceSummaries: {
pageSpeedResults: pageSpeedResults.map((result) => ({
id: result._id,
strategy: result.strategy,
status: result.status,
sourceUrl: result.sourceUrl,
finalUrl: result.finalUrl ?? null,
errorType: result.errorType ?? null,
errorSummary: result.errorSummary ?? null,
normalized: result.normalized ?? null,
fetchedAt: result.fetchedAt,
createdAt: result.createdAt,
})),
crawlPages: crawlPages.map((page) => ({
id: page._id,
sourceUrl: page.sourceUrl,
finalUrl: page.finalUrl,
pageKind: page.pageKind,
title: page.title ?? null,
metaDescription: page.metaDescription ?? null,
headings: page.headings.slice(0, REVIEW_JOIN_LIMIT),
visibleTextExcerpt: page.visibleTextExcerpt ?? null,
hasContactFormSignal: page.hasContactFormSignal,
hasContactCtaSignal: page.hasContactCtaSignal,
createdAt: page.createdAt,
})),
emailCandidates: emailCandidates.map((candidate) => ({
id: candidate._id,
email: candidate.email,
normalizedEmail: candidate.normalizedEmail,
emailSource: candidate.emailSource,
sourceUrl: candidate.sourceUrl,
contactPerson: candidate.contactPerson ?? null,
isBusinessContactAddress: candidate.isBusinessContactAddress,
isGeneric: candidate.isGeneric,
accepted: candidate.accepted,
createdAt: candidate.createdAt,
})),
},
sortAt: Math.max(
lead.updatedAt,
latestOutreach?.updatedAt ?? 0,
audit?.updatedAt ?? 0,
),
};
};
type OutreachRecordInsertArgs = {
leadId: Id<"leads">;
auditId?: Id<"audits">;
strategy: "call_first" | "email_first" | "defer" | "do_not_contact";
phoneScript?: string;
emailSubject?: string;
emailBody?: string;
followUpDraft?: string;
now: number;
};
const buildOutreachRecordsInsertPayload = (args: OutreachRecordInsertArgs) => {
const payload: {
leadId: Id<"leads">;
auditId?: Id<"audits">;
strategy: "call_first" | "email_first" | "defer" | "do_not_contact";
phoneScript?: string;
emailSubject?: string;
emailBody?: string;
followUpDraft?: string;
approvalStatus: "draft";
sendStatus: "not_sent";
responseStatus: "none";
salesStatus: "follow_up_planned";
createdAt: number;
updatedAt: number;
} = {
leadId: args.leadId,
strategy: args.strategy,
approvalStatus: "draft",
sendStatus: "not_sent",
responseStatus: "none",
salesStatus: "follow_up_planned",
createdAt: args.now,
updatedAt: args.now,
};
if (args.auditId !== undefined) {
payload.auditId = args.auditId;
}
if (args.phoneScript !== undefined) {
payload.phoneScript = args.phoneScript;
}
if (args.emailSubject !== undefined) {
payload.emailSubject = args.emailSubject;
}
if (args.emailBody !== undefined) {
payload.emailBody = args.emailBody;
}
if (args.followUpDraft !== undefined) {
payload.followUpDraft = args.followUpDraft;
}
return payload;
};
export const create = mutation({ export const create = mutation({
args: { args: {
leadId: v.id("leads"), leadId: v.id("leads"),
@@ -21,17 +248,37 @@ export const create = mutation({
followUpDraft: v.optional(v.string()), followUpDraft: v.optional(v.string()),
}, },
handler: async (ctx, args) => { handler: async (ctx, args) => {
const now = Date.now(); await requireOperator(ctx);
return await ctx.db.insert("outreachRecords", { const lead = await ctx.db.get(args.leadId);
...args, if (!lead) {
approvalStatus: "draft", throw new Error("Lead wurde nicht gefunden.");
sendStatus: "not_sent", }
responseStatus: "none",
salesStatus: "follow_up_planned", if (args.auditId) {
createdAt: now, const audit = await ctx.db.get(args.auditId);
updatedAt: now, if (!audit) {
}); throw new Error("Audit wurde nicht gefunden.");
}
if (audit.leadId !== args.leadId) {
throw new Error("Audit gehoert nicht zu diesem Lead.");
}
}
const now = Date.now();
return await ctx.db.insert(
"outreachRecords",
buildOutreachRecordsInsertPayload({
leadId: args.leadId,
auditId: args.auditId,
strategy: args.strategy,
phoneScript: args.phoneScript,
emailSubject: args.emailSubject,
emailBody: args.emailBody,
followUpDraft: args.followUpDraft,
now,
}),
);
}, },
}); });
@@ -48,6 +295,21 @@ export const upsertFromAuditGeneration = internalMutation({
handler: async (ctx, args) => { handler: async (ctx, args) => {
const now = Date.now(); const now = Date.now();
const lead = await ctx.db.get(args.leadId);
if (!lead) {
throw new Error("Lead wurde nicht gefunden.");
}
if (args.auditId) {
const audit = await ctx.db.get(args.auditId);
if (!audit) {
throw new Error("Audit wurde nicht gefunden.");
}
if (audit.leadId !== args.leadId) {
throw new Error("Audit gehoert nicht zu diesem Lead.");
}
}
const existing = await ctx.db const existing = await ctx.db
.query("outreachRecords") .query("outreachRecords")
.withIndex("by_leadId", (q) => q.eq("leadId", args.leadId)) .withIndex("by_leadId", (q) => q.eq("leadId", args.leadId))
@@ -56,11 +318,24 @@ export const upsertFromAuditGeneration = internalMutation({
if (existing.length > 0) { if (existing.length > 0) {
const current = existing[0]!; const current = existing[0]!;
if (args.auditId) { if (current.sendStatus === "sent") {
await ctx.db.patch(current._id, { auditId: args.auditId }); return await ctx.db.insert(
"outreachRecords",
buildOutreachRecordsInsertPayload({
leadId: args.leadId,
auditId: args.auditId,
strategy: args.strategy,
phoneScript: args.phoneScript,
emailSubject: args.emailSubject,
emailBody: args.emailBody,
followUpDraft: args.followUpDraft,
now,
}),
);
} }
await ctx.db.patch(current._id, { await ctx.db.patch(current._id, {
...(args.auditId !== undefined ? { auditId: args.auditId } : {}),
strategy: args.strategy, strategy: args.strategy,
...(args.phoneScript !== undefined ? { phoneScript: args.phoneScript } : {}), ...(args.phoneScript !== undefined ? { phoneScript: args.phoneScript } : {}),
...(args.emailSubject !== undefined ...(args.emailSubject !== undefined
@@ -70,21 +345,469 @@ export const upsertFromAuditGeneration = internalMutation({
...(args.followUpDraft !== undefined ...(args.followUpDraft !== undefined
? { followUpDraft: args.followUpDraft } ? { followUpDraft: args.followUpDraft }
: {}), : {}),
approvalStatus: "draft",
updatedAt: now, updatedAt: now,
}); });
return current._id; return current._id;
} }
return await ctx.db.insert("outreachRecords", { return await ctx.db.insert(
...args, "outreachRecords",
buildOutreachRecordsInsertPayload({
leadId: args.leadId,
auditId: args.auditId,
strategy: args.strategy,
phoneScript: args.phoneScript,
emailSubject: args.emailSubject,
emailBody: args.emailBody,
followUpDraft: args.followUpDraft,
now,
}),
);
},
});
export const listReviewWorkspace = query({
args: {
limit: v.optional(v.number()),
},
handler: async (ctx, args) => {
await requireOperator(ctx);
const limit = normalizeListLimit(args.limit);
const candidateLimit = Math.min(limit * 10, 300);
const outreachReadyLeads = await ctx.db
.query("leads")
.withIndex("by_contactStatus_and_updatedAt", (q) =>
q.eq("contactStatus", "outreach_ready"),
)
.order("desc")
.take(candidateLimit);
const draftNotSentOutreach = await ctx.db
.query("outreachRecords")
.withIndex("by_approvalStatus_and_sendStatus_and_updatedAt", (q) =>
q.eq("approvalStatus", "draft").eq("sendStatus", "not_sent"),
)
.order("desc")
.take(candidateLimit);
const draftQueuedOutreach = await ctx.db
.query("outreachRecords")
.withIndex("by_approvalStatus_and_sendStatus_and_updatedAt", (q) =>
q.eq("approvalStatus", "draft").eq("sendStatus", "queued"),
)
.order("desc")
.take(candidateLimit);
const draftFailedOutreach = await ctx.db
.query("outreachRecords")
.withIndex("by_approvalStatus_and_sendStatus_and_updatedAt", (q) =>
q.eq("approvalStatus", "draft").eq("sendStatus", "failed"),
)
.order("desc")
.take(candidateLimit);
const approvedNotSentOutreach = await ctx.db
.query("outreachRecords")
.withIndex("by_approvalStatus_and_sendStatus_and_updatedAt", (q) =>
q.eq("approvalStatus", "approved").eq("sendStatus", "not_sent"),
)
.order("desc")
.take(candidateLimit);
const approvedQueuedOutreach = await ctx.db
.query("outreachRecords")
.withIndex("by_approvalStatus_and_sendStatus_and_updatedAt", (q) =>
q.eq("approvalStatus", "approved").eq("sendStatus", "queued"),
)
.order("desc")
.take(candidateLimit);
const approvedFailedOutreach = await ctx.db
.query("outreachRecords")
.withIndex("by_approvalStatus_and_sendStatus_and_updatedAt", (q) =>
q.eq("approvalStatus", "approved").eq("sendStatus", "failed"),
)
.order("desc")
.take(candidateLimit);
const leadCandidates = new Map<
Id<"leads">,
{ lead: Doc<"leads">; outreach: Doc<"outreachRecords"> | null }
>();
for (const lead of outreachReadyLeads) {
leadCandidates.set(lead._id, { lead, outreach: null });
}
const reviewOutreach = [
...draftNotSentOutreach,
...draftQueuedOutreach,
...draftFailedOutreach,
...approvedNotSentOutreach,
...approvedQueuedOutreach,
...approvedFailedOutreach,
]
.filter((outreach) =>
(outreach.approvalStatus === "draft" ||
outreach.approvalStatus === "approved") &&
outreach.sendStatus !== "sent"
)
.sort((a, b) => b.updatedAt - a.updatedAt);
for (const outreach of reviewOutreach) {
const lead = await ctx.db.get(outreach.leadId);
if (!lead) {
continue;
}
const existing = leadCandidates.get(lead._id);
if (!existing || (existing.outreach?.updatedAt ?? 0) < outreach.updatedAt) {
leadCandidates.set(lead._id, { lead, outreach });
}
}
const rows = await Promise.all(
[...leadCandidates.values()].map(({ lead, outreach }) =>
loadReviewRow(ctx, lead, outreach),
),
);
return rows
.sort((a, b) => b.sortAt - a.sortAt)
.slice(0, limit)
.map(({ sortAt, ...row }) => (void sortAt, row));
},
});
export const saveReviewDraft = mutation({
args: {
id: v.id("outreachRecords"),
strategy: strategy,
phoneScript: v.optional(v.string()),
emailSubject: v.optional(v.string()),
emailBody: v.optional(v.string()),
followUpDraft: v.optional(v.string()),
},
handler: async (ctx, args) => {
await requireOperator(ctx);
const outreach = await ctx.db.get(args.id);
if (!outreach) {
throw new Error("Outreach-Datensatz wurde nicht gefunden.");
}
if (outreach.sendStatus === "sent" || outreach.sendStatus === "queued") {
throw new Error("Gesendete Outreach-Datensaetze koennen nicht bearbeitet werden.");
}
const now = Date.now();
await ctx.db.patch(args.id, {
strategy: args.strategy,
...(args.phoneScript !== undefined ? { phoneScript: args.phoneScript } : {}),
...(args.emailSubject !== undefined
? { emailSubject: args.emailSubject }
: {}),
...(args.emailBody !== undefined ? { emailBody: args.emailBody } : {}),
...(args.followUpDraft !== undefined
? { followUpDraft: args.followUpDraft }
: {}),
approvalStatus: "draft", approvalStatus: "draft",
sendStatus: "not_sent",
responseStatus: "none",
salesStatus: "follow_up_planned",
createdAt: now,
updatedAt: now, updatedAt: now,
}); });
return { id: args.id, approvalStatus: "draft", updatedAt: now };
},
});
export const approveEmailDraft = mutation({
args: {
id: v.id("outreachRecords"),
},
handler: async (ctx, args) => {
await requireOperator(ctx);
const outreach = await ctx.db.get(args.id);
if (!outreach) {
throw new Error("Outreach-Datensatz wurde nicht gefunden.");
}
if (outreach.sendStatus === "sent") {
throw new Error("Gesendete Outreach-Datensaetze koennen nicht freigegeben werden.");
}
if (outreach.sendStatus === "queued") {
throw new Error("Ausstehend freigegebene Outreach-Datensaetze koennen nicht erneut freigegeben werden.");
}
const lead = await ctx.db.get(outreach.leadId);
if (!lead) {
throw new Error("Lead wurde nicht gefunden.");
}
const recipient = lead.email?.trim();
const subject = outreach.emailSubject?.trim();
const body = outreach.emailBody?.trim();
if (!recipient) {
throw new Error("Empfaenger-E-Mail fehlt.");
}
if (!subject) {
throw new Error("E-Mail-Betreff fehlt.");
}
if (!body) {
throw new Error("E-Mail-Text fehlt.");
}
const audit = outreach.auditId ? await ctx.db.get(outreach.auditId) : null;
const now = Date.now();
await ctx.db.patch(args.id, {
approvalStatus: "approved",
updatedAt: now,
});
const sender = process.env.SMTP_FROM?.trim();
if (!sender) {
throw new Error("SMTP-Absender-Adresse fehlt.");
}
return {
id: args.id,
recipient: recipient,
subject: subject,
sender: sender,
auditSlug: audit?.slug ?? null,
approvalStatus: "approved",
updatedAt: now,
};
},
});
export const claimApprovedEmailForSend = internalMutation({
args: {
id: v.id("outreachRecords"),
},
handler: async (ctx, args) => {
await requireOperator(ctx);
const outreach = await ctx.db.get(args.id);
if (!outreach) {
throw new Error("Outreach-Datensatz wurde nicht gefunden.");
}
if (outreach.approvalStatus !== "approved") {
throw new Error("Nur freigegebene Outreachs können versendet werden.");
}
if (outreach.sendStatus === "sent" || outreach.sendStatus === "queued") {
throw new Error("Outreach ist bereits in Versand-Warteschlange oder gesendet.");
}
const lead = await ctx.db.get(outreach.leadId);
if (!lead) {
throw new Error("Lead wurde nicht gefunden.");
}
const recipient = lead.email?.trim();
const subject = outreach.emailSubject?.trim();
const body = outreach.emailBody?.trim();
const sender = process.env.SMTP_FROM?.trim();
if (!recipient) {
throw new Error("Empfaenger-E-Mail fehlt.");
}
if (!subject) {
throw new Error("E-Mail-Betreff fehlt.");
}
if (!body) {
throw new Error("E-Mail-Text fehlt.");
}
if (!sender) {
throw new Error("SMTP-Absender-Adresse fehlt.");
}
const audit = outreach.auditId ? await ctx.db.get(outreach.auditId) : null;
const now = Date.now();
await ctx.db.patch(args.id, {
sendStatus: "queued",
updatedAt: now,
});
return {
outreachId: outreach._id,
id: outreach._id,
leadId: outreach.leadId,
auditId: outreach.auditId,
recipient,
subject,
body,
sender,
auditLink: audit?.slug ? `/audit/${audit.slug}` : null,
};
},
});
const outreachSendAttemptSuccessStatus = "success" as const;
const outreachSendAttemptFailedStatus = "failed" as const;
export const recordEmailSendSuccess = internalMutation({
args: {
id: v.id("outreachRecords"),
recipient: v.string(),
subject: v.string(),
body: v.string(),
sender: v.string(),
auditId: v.optional(v.id("audits")),
auditLink: v.optional(v.union(v.string(), v.null())),
sentAt: v.number(),
smtpMessageId: v.optional(v.string()),
smtpResponse: v.optional(v.string()),
smtpAccepted: v.optional(v.array(v.string())),
smtpRejected: v.optional(v.array(v.string())),
},
handler: async (ctx, args) => {
await requireOperator(ctx);
const outreach = await ctx.db.get(args.id);
if (!outreach) {
throw new Error("Outreach-Datensatz wurde nicht gefunden.");
}
const lead = await ctx.db.get(outreach.leadId);
if (!lead) {
throw new Error("Lead wurde nicht gefunden.");
}
const now = Date.now();
await ctx.db.patch(args.id, {
sendStatus: "sent",
sentAt: args.sentAt,
updatedAt: now,
});
await ctx.db.patch(lead._id, {
contactStatus: "contacted",
updatedAt: now,
});
const attempt: {
outreachId: Id<"outreachRecords">;
leadId: Id<"leads">;
recipient: string;
subject: string;
body: string;
sender: string;
status: typeof outreachSendAttemptSuccessStatus;
sentAt: number;
createdAt: number;
updatedAt: number;
auditId?: Id<"audits">;
auditLink?: string | null;
smtpMessageId?: string;
smtpResponse?: string;
smtpAccepted?: string[];
smtpRejected?: string[];
} = {
outreachId: args.id,
leadId: outreach.leadId,
recipient: args.recipient,
subject: args.subject,
body: args.body,
sender: args.sender,
status: outreachSendAttemptSuccessStatus,
sentAt: args.sentAt,
createdAt: now,
updatedAt: now,
};
if (args.auditId !== undefined) {
attempt.auditId = args.auditId;
}
if (args.auditLink !== undefined) {
attempt.auditLink = args.auditLink;
}
if (args.smtpMessageId !== undefined) {
attempt.smtpMessageId = args.smtpMessageId;
}
if (args.smtpResponse !== undefined) {
attempt.smtpResponse = args.smtpResponse;
}
if (args.smtpAccepted !== undefined) {
attempt.smtpAccepted = args.smtpAccepted;
}
if (args.smtpRejected !== undefined) {
attempt.smtpRejected = args.smtpRejected;
}
await ctx.db.insert("outreachSendAttempts", attempt);
},
});
export const recordEmailSendFailure = internalMutation({
args: {
id: v.id("outreachRecords"),
recipient: v.string(),
subject: v.string(),
body: v.string(),
sender: v.string(),
auditId: v.optional(v.id("audits")),
auditLink: v.optional(v.union(v.string(), v.null())),
errorMessage: v.optional(v.string()),
errorCode: v.optional(v.string()),
errorResponseCode: v.optional(v.number()),
errorResponse: v.optional(v.string()),
},
handler: async (ctx, args) => {
await requireOperator(ctx);
const outreach = await ctx.db.get(args.id);
if (!outreach) {
throw new Error("Outreach-Datensatz wurde nicht gefunden.");
}
const now = Date.now();
await ctx.db.patch(args.id, {
sendStatus: "failed",
updatedAt: now,
});
const attempt: {
outreachId: Id<"outreachRecords">;
leadId: Id<"leads">;
recipient: string;
subject: string;
body: string;
sender: string;
status: typeof outreachSendAttemptFailedStatus;
createdAt: number;
updatedAt: number;
auditId?: Id<"audits">;
auditLink?: string | null;
errorMessage?: string;
errorCode?: string;
errorResponseCode?: number;
errorResponse?: string;
} = {
outreachId: args.id,
leadId: outreach.leadId,
recipient: args.recipient,
subject: args.subject,
body: args.body,
sender: args.sender,
status: outreachSendAttemptFailedStatus,
createdAt: now,
updatedAt: now,
};
if (args.auditId !== undefined) {
attempt.auditId = args.auditId;
}
if (args.auditLink !== undefined) {
attempt.auditLink = args.auditLink;
}
if (args.errorMessage !== undefined) {
attempt.errorMessage = args.errorMessage;
}
if (args.errorCode !== undefined) {
attempt.errorCode = args.errorCode;
}
if (args.errorResponseCode !== undefined) {
attempt.errorResponseCode = args.errorResponseCode;
}
if (args.errorResponse !== undefined) {
attempt.errorResponse = args.errorResponse;
}
await ctx.db.insert("outreachSendAttempts", attempt);
}, },
}); });
@@ -97,6 +820,8 @@ export const list = query({
limit: v.optional(v.number()), limit: v.optional(v.number()),
}, },
handler: async (ctx, args) => { handler: async (ctx, args) => {
await requireOperator(ctx);
const limit = normalizeListLimit(args.limit); const limit = normalizeListLimit(args.limit);
if (args.leadId) { if (args.leadId) {

View File

@@ -0,0 +1,335 @@
"use node";
import { internal } from "./_generated/api";
import { action, type ActionCtx } from "./_generated/server";
import { v } from "convex/values";
import nodemailer from "nodemailer";
import type { SentMessageInfo } from "nodemailer";
import type { Id } from "./_generated/dataModel";
type SendRecipientList = string[];
type SmtpErrorDetails = {
message: string;
code?: string;
responseCode?: number;
response?: string;
accepted?: SendRecipientList;
rejected?: SendRecipientList;
};
const DEFAULT_SMTP_PORT = 465;
const SMTP_REQUIRED_FIELDS = [
"SMTP_HOST",
"SMTP_USER",
"SMTP_PASSWORD",
"SMTP_FROM",
] as const;
async function requireOperator(ctx: ActionCtx): Promise<void> {
const identity = await ctx.auth.getUserIdentity();
if (!identity) {
throw new Error("Nicht autorisiert.");
}
}
function escapeRegExp(value: string) {
return value.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
}
function sanitizeValue(value: string | undefined | null): string | undefined {
if (!value) {
return value === "" ? "" : undefined;
}
let safe = value;
for (const secretName of SMTP_REQUIRED_FIELDS) {
const secret = process.env[secretName];
if (secret) {
safe = safe.replace(new RegExp(escapeRegExp(secret), "g"), "[REDACTED]");
}
}
return safe
.replace(
/\b(?:host|user|userId|userID|password|pass|secret)\s*[:=]\s*[^\s\"']+/gi,
"[REDACTED]",
)
.trim();
}
function parsePort(raw: string | undefined): number {
const fallback = DEFAULT_SMTP_PORT;
const normalized = raw?.trim();
if (!normalized) {
return fallback;
}
const parsed = Number.parseInt(normalized, 10);
if (!Number.isFinite(parsed)) {
throw new Error("SMTP-Port ist ungültig.");
}
if (parsed < 1 || parsed > 65_535) {
throw new Error("SMTP-Port liegt außerhalb gültiger Grenzen.");
}
return parsed;
}
function parseResponseCode(value: unknown): number | undefined {
if (typeof value === "number" && Number.isFinite(value)) {
return value;
}
if (typeof value === "string") {
const parsed = Number.parseInt(value, 10);
return Number.isFinite(parsed) ? parsed : undefined;
}
return undefined;
}
function normalizeRecipientList(value: unknown): SendRecipientList {
if (!Array.isArray(value)) {
return [];
}
return value
.map((entry) => {
return typeof entry === "string" ? entry : String(entry);
})
.filter(Boolean);
}
function extractSmtpError(error: unknown): SmtpErrorDetails {
if (error instanceof Error) {
const errorCode = (error as { code?: unknown }).code;
const smtpCode =
typeof errorCode === "string" ? errorCode : undefined;
return {
message: error.message || "SMTP-Fehler ohne Nachricht.",
code: smtpCode,
responseCode: parseResponseCode(
(error as { responseCode?: unknown }).responseCode,
),
response: (error as { response?: unknown }).response as string | undefined,
};
}
if (typeof error === "object" && error !== null) {
const errorAsRecord = error as {
message?: unknown;
code?: unknown;
responseCode?: unknown;
response?: unknown;
accepted?: unknown;
rejected?: unknown;
};
return {
message:
typeof errorAsRecord.message === "string"
? errorAsRecord.message
: "SMTP-Fehler ohne Nachricht.",
code:
typeof errorAsRecord.code === "string"
? errorAsRecord.code
: undefined,
responseCode: parseResponseCode(errorAsRecord.responseCode),
response:
typeof errorAsRecord.response === "string"
? errorAsRecord.response
: undefined,
accepted: normalizeRecipientList(errorAsRecord.accepted),
rejected: normalizeRecipientList(errorAsRecord.rejected),
};
}
const message = typeof error === "string" ? error : "SMTP-Fehler ohne Nachricht.";
return { message };
}
function toSanitizedErrorForLog(error: unknown) {
const parsed = extractSmtpError(error);
return {
message: sanitizeValue(parsed.message) ?? "SMTP-Fehler ohne Nachricht.",
code: sanitizeValue(parsed.code),
responseCode: parsed.responseCode,
response: sanitizeValue(parsed.response),
};
}
function sanitizeSmtpError(error: unknown) {
return toSanitizedErrorForLog(error);
}
type OutreachSendSnapshot = {
outreachId: Id<"outreachRecords">;
id?: Id<"outreachRecords">;
leadId: Id<"leads">;
auditId?: Id<"audits">;
recipient: string;
subject: string;
body: string;
sender: string;
auditLink?: string | null;
};
export const sendApprovedEmail = action({
args: {
id: v.id("outreachRecords"),
},
handler: async (
ctx: ActionCtx,
args: {
id: Id<"outreachRecords">;
},
): Promise<{
ok: boolean;
outreachId: Id<"outreachRecords">;
}> => {
await requireOperator(ctx);
const snapshot: OutreachSendSnapshot = await ctx.runMutation(
internal.outreach.claimApprovedEmailForSend,
{
id: args.id,
},
);
try {
const smtpPort = parsePort(process.env.SMTP_PORT);
const smtpHost = process.env.SMTP_HOST?.trim();
const smtpUser = process.env.SMTP_USER?.trim();
const smtpPassword = process.env.SMTP_PASSWORD?.trim();
if (!smtpHost || !smtpUser || !smtpPassword || !snapshot.sender) {
throw new Error("SMTP-Konfiguration ist unvollständig.");
}
const isSecureSmtp = smtpPort === 465;
const transporter = nodemailer.createTransport({
host: smtpHost,
port: smtpPort,
secure: isSecureSmtp,
auth: {
user: smtpUser,
pass: smtpPassword,
},
});
const result = (await transporter.sendMail({
from: snapshot.sender,
to: snapshot.recipient,
subject: snapshot.subject,
text: snapshot.body,
})) as SentMessageInfo;
const successPayload: {
id: Id<"outreachRecords">;
recipient: string;
subject: string;
body: string;
sender: string;
sentAt: number;
auditId?: Id<"audits">;
auditLink?: string | null;
smtpMessageId?: string;
smtpResponse?: string;
smtpAccepted?: string[];
smtpRejected?: string[];
} = {
id: args.id,
recipient: snapshot.recipient,
subject: snapshot.subject,
body: snapshot.body,
sender: snapshot.sender,
sentAt: Date.now(),
};
if (snapshot.auditId !== undefined) {
successPayload.auditId = snapshot.auditId;
}
if (snapshot.auditLink !== undefined) {
successPayload.auditLink = snapshot.auditLink;
}
if (result.messageId !== undefined) {
successPayload.smtpMessageId = sanitizeValue(result.messageId);
}
if (result.response !== undefined) {
successPayload.smtpResponse = sanitizeValue(result.response);
}
if (Array.isArray(result.accepted) && result.accepted.length > 0) {
successPayload.smtpAccepted = normalizeRecipientList(result.accepted);
}
if (Array.isArray(result.rejected) && result.rejected.length > 0) {
successPayload.smtpRejected = normalizeRecipientList(result.rejected);
}
await ctx.runMutation(internal.outreach.recordEmailSendSuccess, successPayload);
return {
ok: true,
outreachId: snapshot.outreachId,
};
} catch (error) {
const sanitized = sanitizeSmtpError(error);
const failure = extractSmtpError(error);
const failurePayload: {
id: Id<"outreachRecords">;
recipient: string;
subject: string;
body: string;
sender: string;
auditId?: Id<"audits">;
auditLink?: string | null;
errorMessage?: string;
errorCode?: string;
errorResponseCode?: number;
errorResponse?: string;
} = {
id: args.id,
recipient: snapshot.recipient,
subject: snapshot.subject,
body: snapshot.body,
sender: snapshot.sender,
};
if (snapshot.auditId !== undefined) {
failurePayload.auditId = snapshot.auditId;
}
if (snapshot.auditLink !== undefined) {
failurePayload.auditLink = snapshot.auditLink;
}
if (failure.message) {
failurePayload.errorMessage = sanitizeValue(failure.message);
}
if (failure.code !== undefined) {
failurePayload.errorCode = sanitizeValue(failure.code);
}
if (failure.responseCode !== undefined) {
failurePayload.errorResponseCode = failure.responseCode;
}
if (failure.response !== undefined) {
failurePayload.errorResponse = sanitizeValue(failure.response);
}
console.error("SMTP-Versand fehlgeschlagen.", {
outreachId: snapshot.outreachId,
leadId: snapshot.leadId,
message: sanitized.message,
code: sanitized.code,
responseCode: sanitized.responseCode,
response: sanitized.response,
});
await ctx.runMutation(
internal.outreach.recordEmailSendFailure,
failurePayload,
);
throw new Error("SMTP-Versand ist fehlgeschlagen.");
}
},
});

View File

@@ -56,6 +56,10 @@ const outreachSendStatus = v.union(
v.literal("sent"), v.literal("sent"),
v.literal("failed"), v.literal("failed"),
); );
const outreachSendAttemptStatus = v.union(
v.literal("success"),
v.literal("failed"),
);
const outreachResponseStatus = v.union( const outreachResponseStatus = v.union(
v.literal("none"), v.literal("none"),
v.literal("manual_reply_recorded"), v.literal("manual_reply_recorded"),
@@ -253,6 +257,7 @@ export default defineSchema({
.index("by_campaignId", ["campaignId"]) .index("by_campaignId", ["campaignId"])
.index("by_discoveryRunId", ["discoveryRunId"]) .index("by_discoveryRunId", ["discoveryRunId"])
.index("by_contactStatus", ["contactStatus"]) .index("by_contactStatus", ["contactStatus"])
.index("by_contactStatus_and_updatedAt", ["contactStatus", "updatedAt"])
.index("by_normalizedEmail", ["normalizedEmail"]) .index("by_normalizedEmail", ["normalizedEmail"])
.index("by_normalizedPhone", ["normalizedPhone"]) .index("by_normalizedPhone", ["normalizedPhone"])
.index("by_normalizedCompanyName_and_normalizedAddress", [ .index("by_normalizedCompanyName_and_normalizedAddress", [
@@ -490,7 +495,41 @@ export default defineSchema({
.index("by_leadId", ["leadId"]) .index("by_leadId", ["leadId"])
.index("by_auditId", ["auditId"]) .index("by_auditId", ["auditId"])
.index("by_approvalStatus", ["approvalStatus"]) .index("by_approvalStatus", ["approvalStatus"])
.index("by_sendStatus", ["sendStatus"]), .index("by_approvalStatus_and_updatedAt", ["approvalStatus", "updatedAt"])
.index("by_approvalStatus_and_sendStatus_and_updatedAt", [
"approvalStatus",
"sendStatus",
"updatedAt",
])
.index("by_sendStatus", ["sendStatus"])
.index("by_sendStatus_and_updatedAt", ["sendStatus", "updatedAt"]),
outreachSendAttempts: defineTable({
outreachId: v.id("outreachRecords"),
leadId: v.id("leads"),
auditId: v.optional(v.id("audits")),
recipient: v.string(),
subject: v.string(),
body: v.string(),
sender: v.string(),
auditLink: v.optional(v.union(v.string(), v.null())),
status: outreachSendAttemptStatus,
sentAt: v.optional(v.number()),
smtpMessageId: v.optional(v.string()),
smtpResponse: v.optional(v.string()),
smtpAccepted: v.optional(v.array(v.string())),
smtpRejected: v.optional(v.array(v.string())),
errorMessage: v.optional(v.string()),
errorCode: v.optional(v.string()),
errorResponseCode: v.optional(v.number()),
errorResponse: v.optional(v.string()),
createdAt: v.number(),
updatedAt: v.number(),
})
.index("by_outreachId", ["outreachId"])
.index("by_leadId", ["leadId"])
.index("by_status", ["status"])
.index("by_createdAt", ["createdAt"]),
blacklistEntries: defineTable({ blacklistEntries: defineTable({
type: blacklistType, type: blacklistType,

View File

@@ -1,5 +1,30 @@
import { convexBetterAuthNextJs } from "@convex-dev/better-auth/nextjs"; import { convexBetterAuthNextJs } from "@convex-dev/better-auth/nextjs";
function getErrorText(error: unknown): string {
if (error instanceof Error) {
return error.message;
}
if (typeof error === "string") {
return error;
}
if (error && typeof error === "object") {
const { data, message } = error as { data?: unknown; message?: unknown };
return [message, data]
.filter((value): value is string => typeof value === "string")
.join(" ");
}
return "";
}
function isConvexAuthError(error: unknown): boolean {
return /\b(Unauthenticated|Unauthorized|Not authenticated)\b/i.test(
getErrorText(error),
);
}
export const { export const {
handler, handler,
preloadAuthQuery, preloadAuthQuery,
@@ -11,4 +36,8 @@ export const {
} = convexBetterAuthNextJs({ } = convexBetterAuthNextJs({
convexUrl: process.env.NEXT_PUBLIC_CONVEX_URL!, convexUrl: process.env.NEXT_PUBLIC_CONVEX_URL!,
convexSiteUrl: process.env.NEXT_PUBLIC_CONVEX_SITE_URL!, convexSiteUrl: process.env.NEXT_PUBLIC_CONVEX_SITE_URL!,
jwtCache: {
enabled: true,
isAuthError: isConvexAuthError,
},
}); });

View File

@@ -286,7 +286,8 @@ function getLeadFunnelStageId(lead: LeadFunnelInput): LeadFunnelStageId {
if ( if (
lead.contactStatus === "outreach_ready" || lead.contactStatus === "outreach_ready" ||
lead.outreach?.approvalStatus === "draft" lead.outreach?.approvalStatus === "draft" ||
lead.outreach?.approvalStatus === "approved"
) { ) {
return "review_open"; return "review_open";
} }

View File

@@ -22,6 +22,7 @@
"convex": "^1.40.0", "convex": "^1.40.0",
"lucide-react": "^1.17.0", "lucide-react": "^1.17.0",
"next": "16.2.7", "next": "16.2.7",
"nodemailer": "^8.0.10",
"playwright-core": "^1.60.0", "playwright-core": "^1.60.0",
"radix-ui": "^1.4.3", "radix-ui": "^1.4.3",
"react": "19.2.4", "react": "19.2.4",
@@ -35,6 +36,7 @@
"devDependencies": { "devDependencies": {
"@tailwindcss/postcss": "^4", "@tailwindcss/postcss": "^4",
"@types/node": "^20", "@types/node": "^20",
"@types/nodemailer": "^8.0.0",
"@types/react": "^19", "@types/react": "^19",
"@types/react-dom": "^19", "@types/react-dom": "^19",
"eslint": "^9", "eslint": "^9",

19
pnpm-lock.yaml generated
View File

@@ -41,6 +41,9 @@ importers:
next: next:
specifier: 16.2.7 specifier: 16.2.7
version: 16.2.7(@babel/core@7.29.7)(@opentelemetry/api@1.9.1)(react-dom@19.2.4(react@19.2.4))(react@19.2.4) version: 16.2.7(@babel/core@7.29.7)(@opentelemetry/api@1.9.1)(react-dom@19.2.4(react@19.2.4))(react@19.2.4)
nodemailer:
specifier: ^8.0.10
version: 8.0.10
playwright-core: playwright-core:
specifier: ^1.60.0 specifier: ^1.60.0
version: 1.60.0 version: 1.60.0
@@ -75,6 +78,9 @@ importers:
'@types/node': '@types/node':
specifier: ^20 specifier: ^20
version: 20.19.41 version: 20.19.41
'@types/nodemailer':
specifier: ^8.0.0
version: 8.0.0
'@types/react': '@types/react':
specifier: ^19 specifier: ^19
version: 19.2.16 version: 19.2.16
@@ -1758,6 +1764,9 @@ packages:
'@types/node@20.19.41': '@types/node@20.19.41':
resolution: {integrity: sha512-ECymXOukMnOoVkC2bb1Vc/w/836DXncOg5m8Xj1RH7xSHZJWNYY6Zh7EH477vcnD5egKNNfy2RpNOmuChhFPgQ==} resolution: {integrity: sha512-ECymXOukMnOoVkC2bb1Vc/w/836DXncOg5m8Xj1RH7xSHZJWNYY6Zh7EH477vcnD5egKNNfy2RpNOmuChhFPgQ==}
'@types/nodemailer@8.0.0':
resolution: {integrity: sha512-fyf8jWULsCo0d0BuoQ75i6IeoHs47qcqxWc7yUdUcV0pOZGjUTTOvwdG1PRXUDqN/8A64yQdQdnA2pZgcdi+cA==}
'@types/react-dom@19.2.3': '@types/react-dom@19.2.3':
resolution: {integrity: sha512-jp2L/eY6fn+KgVVQAOqYItbF0VY/YApe5Mz2F0aykSO8gx31bYCZyvSeYxCHKvzHG5eZjc+zyaS5BrBWya2+kQ==} resolution: {integrity: sha512-jp2L/eY6fn+KgVVQAOqYItbF0VY/YApe5Mz2F0aykSO8gx31bYCZyvSeYxCHKvzHG5eZjc+zyaS5BrBWya2+kQ==}
peerDependencies: peerDependencies:
@@ -3523,6 +3532,10 @@ packages:
resolution: {integrity: sha512-Uzmd6LXpouKo8EUK68IjH4+E01w/hXyV3R3g/geCJo+rXLNfh1xucB+LOzYEOQPSiUK3h/xZf0cQGcSsmyL2Og==} resolution: {integrity: sha512-Uzmd6LXpouKo8EUK68IjH4+E01w/hXyV3R3g/geCJo+rXLNfh1xucB+LOzYEOQPSiUK3h/xZf0cQGcSsmyL2Og==}
engines: {node: '>=18'} engines: {node: '>=18'}
nodemailer@8.0.10:
resolution: {integrity: sha512-BLFuSth7QtHOkBzyqTehWWyub0NTRDuK2Q2SQfnGLsrJnzyU+Yeh4WpV1eZGuARFj1xQJHIdnTuJZLP+b9R1GQ==}
engines: {node: '>=6.0.0'}
npm-run-path@4.0.1: npm-run-path@4.0.1:
resolution: {integrity: sha512-S48WzZW777zhNIrn7gxOlISNAqi9ZC/uQFnRdbeIHhZhCA6UqpkOT8T1G7BvfdgP4Er8gF4sUbaS0i7QvIfCWw==} resolution: {integrity: sha512-S48WzZW777zhNIrn7gxOlISNAqi9ZC/uQFnRdbeIHhZhCA6UqpkOT8T1G7BvfdgP4Er8gF4sUbaS0i7QvIfCWw==}
engines: {node: '>=8'} engines: {node: '>=8'}
@@ -5941,6 +5954,10 @@ snapshots:
dependencies: dependencies:
undici-types: 6.21.0 undici-types: 6.21.0
'@types/nodemailer@8.0.0':
dependencies:
'@types/node': 20.19.41
'@types/react-dom@19.2.3(@types/react@19.2.16)': '@types/react-dom@19.2.3(@types/react@19.2.16)':
dependencies: dependencies:
'@types/react': 19.2.16 '@types/react': 19.2.16
@@ -7733,6 +7750,8 @@ snapshots:
node-releases@2.0.47: {} node-releases@2.0.47: {}
nodemailer@8.0.10: {}
npm-run-path@4.0.1: npm-run-path@4.0.1:
dependencies: dependencies:
path-key: 3.1.1 path-key: 3.1.1

View File

@@ -0,0 +1,23 @@
import assert from "node:assert/strict";
import { readFile } from "node:fs/promises";
import { join } from "node:path";
import test from "node:test";
const authServerPath = join(process.cwd(), "lib", "auth-server.ts");
test("server auth utilities reuse valid Convex JWT cookies", async () => {
const source = await readFile(authServerPath, "utf8");
assert.match(source, /jwtCache:\s*\{/);
assert.match(source, /enabled:\s*true/);
assert.match(source, /isAuthError:\s*isConvexAuthError/);
});
test("server auth error predicate keeps stale token refresh possible", async () => {
const source = await readFile(authServerPath, "utf8");
assert.match(source, /function isConvexAuthError\(error: unknown\): boolean/);
assert.match(source, /Unauthenticated/);
assert.match(source, /Unauthorized/);
assert.doesNotMatch(source, /InvalidToken/);
});

View File

@@ -146,6 +146,37 @@ test("groupLeadFunnelCards derives review, follow-up, and deferred columns witho
); );
}); });
test("groupLeadFunnelCards keeps approved unsent outreach in the review-open funnel", () => {
const groups = groupLeadFunnelCards([
{
id: "lead-approved-unsent",
companyName: "Optik Meyer",
city: "Freiburg",
priority: "medium",
contactStatus: "new",
blacklistStatus: "clear",
outreach: {
approvalStatus: "approved",
sendStatus: "not_sent",
responseStatus: "none",
salesStatus: "follow_up_planned",
},
},
]);
assert.deepEqual(
groups.map((group) => [group.stage.id, group.cards.map((card) => card.id)]),
[
["missing_contact", []],
["audit_ready", []],
["review_open", ["lead-approved-unsent"]],
["contacted", []],
["follow_up", []],
["deferred", []],
],
);
});
test("toLeadFunnelCard maps blocked priority to deferred stage with blocker label", () => { test("toLeadFunnelCard maps blocked priority to deferred stage with blocker label", () => {
const card = toLeadFunnelCard({ const card = toLeadFunnelCard({
id: "lead-blocked", id: "lead-blocked",

View File

@@ -0,0 +1,30 @@
import assert from "node:assert/strict";
import { readFile } from "node:fs/promises";
import { join } from "node:path";
import test from "node:test";
test("dashboard sidebar links do not prefetch protected routes", async () => {
const source = await readFile(
join(process.cwd(), "components", "dashboard-sidebar.tsx"),
"utf8",
);
const linkMatch = source.match(/<Link[\s\S]*?href=\{item\.href\}[\s\S]*?>/);
assert.ok(linkMatch, "Dashboard sidebar should render dashboard nav Links.");
assert.match(linkMatch[0], /prefetch=\{false\}/);
});
test("lead funnel card action links do not fan out prefetches", async () => {
const source = await readFile(
join(process.cwd(), "components", "lead-funnel-board.tsx"),
"utf8",
);
const actionLinkMatch = source.match(
/<Link[\s\S]*?href=\{stageActionHref\[card\.stageId\]\}[\s\S]*?>/,
);
assert.ok(actionLinkMatch, "Lead funnel cards should link to stage actions.");
assert.match(actionLinkMatch[0], /prefetch=\{false\}/);
});

View File

@@ -0,0 +1,23 @@
import assert from "node:assert/strict";
import { readFile } from "node:fs/promises";
import { join } from "node:path";
import test from "node:test";
const dashboardThemePath = join(
process.cwd(),
"components",
"dashboard-theme.tsx",
);
test("DashboardThemeProvider keeps server and first client render stable", async () => {
const source = await readFile(dashboardThemePath, "utf8");
assert.match(source, /useSyncExternalStore\(/);
assert.match(source, /function getServerDashboardTheme\(\): DashboardTheme \{/);
assert.match(source, /return "light";/);
assert.doesNotMatch(
source,
/useState<DashboardTheme>\(\(\) => \{[\s\S]*?localStorage/,
);
assert.doesNotMatch(source, /setTheme\(/);
});

View File

@@ -0,0 +1,743 @@
import assert from "node:assert/strict";
import { existsSync, readFileSync } from "node:fs";
import { join } from "node:path";
import test from "node:test";
import ts from "typescript";
const outreachPath = join(process.cwd(), "convex", "outreach.ts");
const schemaPath = join(process.cwd(), "convex", "schema.ts");
const actionPath = join(process.cwd(), "convex", "outreachSendAction.ts");
const outreachSource = existsSync(outreachPath)
? readFileSync(outreachPath, "utf8")
: "";
const schemaSource = existsSync(schemaPath)
? readFileSync(schemaPath, "utf8")
: "";
const outreachSendActionSource = existsSync(actionPath)
? readFileSync(actionPath, "utf8")
: "";
const sourceFile = ts.createSourceFile(
"outreach.ts",
outreachSource,
ts.ScriptTarget.ES2022,
true,
ts.ScriptKind.TS,
);
const actionSourceFile = ts.createSourceFile(
"outreachSendAction.ts",
outreachSendActionSource,
ts.ScriptTarget.ES2022,
true,
ts.ScriptKind.TS,
);
function getExportedConstNames(file: ts.SourceFile) {
const names = new Set<string>();
const visit = (node: ts.Node) => {
if (ts.isVariableStatement(node)) {
const isExported = node.modifiers?.some(
(mod) => mod.kind === ts.SyntaxKind.ExportKeyword,
);
const isConst = Boolean(node.declarationList.flags & ts.NodeFlags.Const);
if (isExported && isConst) {
for (const declaration of node.declarationList.declarations) {
if (ts.isIdentifier(declaration.name)) {
names.add(declaration.name.text);
}
}
}
}
ts.forEachChild(node, visit);
};
ts.forEachChild(file, visit);
return names;
}
function extractExportSource(name: string) {
const marker = `export const ${name} = `;
const declarationIndex = outreachSource.indexOf(marker);
assert.notEqual(declarationIndex, -1, `Expected declaration for ${name}.`);
const openBraceIndex = outreachSource.indexOf("{", declarationIndex);
let depth = 0;
let end = -1;
for (let index = openBraceIndex; index < outreachSource.length; index += 1) {
const char = outreachSource[index];
if (char === "{") {
depth += 1;
} else if (char === "}") {
depth -= 1;
if (depth === 0) {
end = index;
break;
}
}
}
assert.notEqual(end, -1, `Expected balanced braces for ${name}.`);
return outreachSource.slice(openBraceIndex, end + 1);
}
function extractTableSource(tableName: string) {
const marker = `${tableName}: defineTable({`;
const start = schemaSource.indexOf(marker);
if (start === -1) {
return "";
}
const openBraceIndex = schemaSource.indexOf("{", start + marker.length - 1);
let depth = 0;
let end = -1;
for (let index = openBraceIndex; index < schemaSource.length; index += 1) {
const char = schemaSource[index];
if (char === "{") {
depth += 1;
} else if (char === "}") {
depth -= 1;
if (depth === 0) {
end = index;
break;
}
}
}
if (end === -1) {
return "";
}
return schemaSource.slice(openBraceIndex, end + 1);
}
function hasPattern(source: string, pattern: RegExp, message: string) {
assert.equal(pattern.test(source), true, message);
}
function lacksPattern(source: string, pattern: RegExp, message: string) {
assert.equal(pattern.test(source), false, message);
}
test("outreach review module exports authenticated review contracts", () => {
assert.equal(existsSync(outreachPath), true, "outreach.ts should be present.");
const exports = getExportedConstNames(sourceFile);
for (const exportName of [
"listReviewWorkspace",
"saveReviewDraft",
"approveEmailDraft",
]) {
assert.equal(exports.has(exportName), true, `Expected export: ${exportName}`);
}
hasPattern(
outreachSource,
/const requireOperator\s*=\s*async\s*\(\s*ctx:\s*(?:QueryCtx\s*\|\s*MutationCtx|MutationCtx\s*\|\s*QueryCtx)\s*\)/,
"Module should define a local requireOperator helper usable from queries and mutations.",
);
hasPattern(
outreachSource,
/ctx\.auth\.getUserIdentity\(\)/,
"requireOperator should derive the operator identity from Convex auth.",
);
hasPattern(
outreachSource,
/Nicht autorisiert/,
"Unauthenticated review calls should fail clearly.",
);
});
test("outreach record inserts never spread args directly", () => {
const createSource = extractExportSource("create");
const upsertSource = extractExportSource("upsertFromAuditGeneration");
hasPattern(
createSource,
/buildOutreachRecordsInsertPayload/,
"create should delegate outreachRecords insert payload construction to a local helper.",
);
hasPattern(
upsertSource,
/buildOutreachRecordsInsertPayload/,
"upsertFromAuditGeneration should delegate outreachRecords insert payload construction to a local helper.",
);
lacksPattern(createSource, /\.\.\.args/, "create should not spread raw args into db insert payloads.");
lacksPattern(
createSource,
/ctx\.db\.insert\(\s*"outreachRecords"[\s\S]*\.\.\./,
"create should build explicit insert object fields.",
);
lacksPattern(upsertSource, /\.\.\.args/, "upsertFromAuditGeneration should not spread raw args into db insert payloads.");
lacksPattern(
upsertSource,
/ctx\.db\.insert\(\s*"outreachRecords"[\s\S]*\.\.\.args/,
"upsertFromAuditGeneration should build explicit insert object fields.",
);
});
test("outreach record payload builder keeps optional fields explicit", () => {
hasPattern(
outreachSource,
/const buildOutreachRecordsInsertPayload = /,
"create/upsert should use a dedicated insert payload helper.",
);
hasPattern(
outreachSource,
/if \(args\.auditId !== undefined\) \{[\s\S]*auditId:/,
"Insert payload should include optional auditId only when it is set.",
);
hasPattern(
outreachSource,
/if \(args\.phoneScript !== undefined\) \{[\s\S]*phoneScript:/,
"Insert payload should include optional phoneScript only when it is set.",
);
hasPattern(
outreachSource,
/if \(args\.emailSubject !== undefined\) \{[\s\S]*emailSubject:/,
"Insert payload should include optional emailSubject only when it is set.",
);
hasPattern(
outreachSource,
/if \(args\.emailBody !== undefined\) \{[\s\S]*emailBody:/,
"Insert payload should include optional emailBody only when it is set.",
);
hasPattern(
outreachSource,
/if \(args\.followUpDraft !== undefined\) \{[\s\S]*followUpDraft:/,
"Insert payload should include optional followUpDraft only when it is set.",
);
});
test("listReviewWorkspace is bounded, authenticated, and joins review context", () => {
const listSource = extractExportSource("listReviewWorkspace");
const reviewSource = `${listSource}\n${outreachSource}`;
hasPattern(outreachSource, /export const listReviewWorkspace = query\(/, "Review workspace should be a public query.");
hasPattern(listSource, /requireOperator\(ctx\)/, "Review workspace should require auth.");
hasPattern(listSource, /limit:\s*v\.optional\(v\.number\(\)\)/, "Review workspace should accept optional limit.");
hasPattern(listSource, /normalizeListLimit\(args\.limit\)/, "Review workspace should normalize the requested limit.");
lacksPattern(listSource, /\.collect\(/, "Review workspace must not use unbounded collect().");
hasPattern(
listSource,
/query\("leads"\)[\s\S]*?withIndex\("by_contactStatus_and_updatedAt"[\s\S]*?eq\("contactStatus",\s*"outreach_ready"\)[\s\S]*?\.order\("desc"\)[\s\S]*?\.take\(candidateLimit\)/,
"Review workspace should include newest outreach-ready leads via contactStatus+updatedAt.",
);
for (const [approvalStatus, sendStatus] of [
["draft", "not_sent"],
["draft", "queued"],
["draft", "failed"],
["approved", "not_sent"],
["approved", "queued"],
["approved", "failed"],
]) {
hasPattern(
listSource,
new RegExp(
`query\\("outreachRecords"\\)[\\s\\S]*?withIndex\\("by_approvalStatus_and_sendStatus_and_updatedAt"[\\s\\S]*?eq\\("approvalStatus",\\s*"${approvalStatus}"\\)[\\s\\S]*?eq\\("sendStatus",\\s*"${sendStatus}"\\)[\\s\\S]*?\\.order\\("desc"\\)[\\s\\S]*?\\.take\\(candidateLimit\\)`,
),
`Review workspace should fetch newest ${approvalStatus}/${sendStatus} outreach via combined eligibility+updatedAt index.`,
);
}
lacksPattern(
listSource,
/withIndex\("by_approvalStatus_and_updatedAt"/,
"Review workspace should not depend on approval-only bounded windows for outreach eligibility.",
);
lacksPattern(
listSource,
/withIndex\("by_sendStatus_and_updatedAt"/,
"Review workspace should not depend on send-only bounded windows for outreach eligibility.",
);
hasPattern(
listSource,
/\.\.\.draftNotSentOutreach[\s\S]*\.\.\.draftQueuedOutreach[\s\S]*\.\.\.draftFailedOutreach[\s\S]*\.\.\.approvedNotSentOutreach[\s\S]*\.\.\.approvedQueuedOutreach[\s\S]*\.\.\.approvedFailedOutreach/,
"Review workspace should combine only eligible approval/send-status candidate windows.",
);
hasPattern(
listSource,
/approvalStatus\s*===\s*"draft"[\s\S]*?approvalStatus\s*===\s*"approved"/,
"Review workspace should include draft and approved unsent outreach records.",
);
hasPattern(
listSource,
/sendStatus\s*!==\s*"sent"/,
"Review workspace should exclude sent outreach records.",
);
hasPattern(
listSource,
/sort\(\(\s*a,\s*b\s*\)\s*=>\s*b\.sortAt\s*-\s*a\.sortAt\s*\)/,
"Review rows should be newest first.",
);
hasPattern(listSource, /slice\(0,\s*limit\)/, "Review rows should be capped to the normalized limit.");
for (const tableName of [
"audits",
"auditGenerations",
"pageSpeedResults",
"websiteCrawlPages",
"websiteEmailCandidates",
]) {
hasPattern(
reviewSource,
new RegExp(`query\\("${tableName}"\\)[\\s\\S]*?\\.take\\(\\s*\\d+\\s*\\)`),
`${tableName} join should be bounded with take(n).`,
);
}
for (const fieldName of [
"lead",
"latestOutreach",
"audit",
"auditGenerations",
"usedSkills",
"skillSummaries",
"sourceSummaries",
"pageSpeedResults",
"crawlPages",
"emailCandidates",
]) {
hasPattern(
reviewSource,
new RegExp(`${fieldName}:`),
`Review rows should include ${fieldName}.`,
);
}
});
test("schema defines recency indexes for outreach review bounded reads", () => {
assert.equal(existsSync(schemaPath), true, "schema.ts should be present.");
for (const [indexName, fieldsPattern] of [
["by_contactStatus_and_updatedAt", String.raw`\[\s*"contactStatus",\s*"updatedAt",?\s*\]`],
["by_approvalStatus_and_updatedAt", String.raw`\[\s*"approvalStatus",\s*"updatedAt",?\s*\]`],
["by_sendStatus_and_updatedAt", String.raw`\[\s*"sendStatus",\s*"updatedAt",?\s*\]`],
[
"by_approvalStatus_and_sendStatus_and_updatedAt",
String.raw`\[\s*"approvalStatus",\s*"sendStatus",\s*"updatedAt",?\s*\]`,
],
]) {
hasPattern(
schemaSource,
new RegExp(`\\.index\\("${indexName}",\\s*${fieldsPattern}`),
`Schema should define ${indexName} for newest-first bounded review reads.`,
);
}
});
test("upsertFromAuditGeneration preserves review boundaries for generated copy", () => {
const upsertSource = extractExportSource("upsertFromAuditGeneration");
hasPattern(
outreachSource,
/export const upsertFromAuditGeneration = internalMutation\(/,
"upsertFromAuditGeneration should remain an internal mutation.",
);
hasPattern(upsertSource, /ctx\.db\.get\(args\.leadId\)/, "upsert should verify the lead exists.");
hasPattern(upsertSource, /!lead/, "upsert should reject missing leads.");
hasPattern(upsertSource, /ctx\.db\.get\(args\.auditId\)/, "upsert should load provided audits.");
hasPattern(upsertSource, /!audit/, "upsert should reject missing audits.");
hasPattern(
upsertSource,
/audit\.leadId\s*!==\s*args\.leadId/,
"upsert should reject auditId values that belong to a different lead.",
);
hasPattern(
upsertSource,
/current\.sendStatus\s*===\s*"sent"[\s\S]*?buildOutreachRecordsInsertPayload/,
"upsert should create a new draft record instead of patching a sent outreach record.",
);
hasPattern(
upsertSource,
/ctx\.db\.patch\(current\._id,[\s\S]*approvalStatus:\s*"draft"/,
"Generated copy changes should reset existing unsent outreach records to draft.",
);
hasPattern(
outreachSource,
/buildOutreachRecordsInsertPayload[\s\S]*approvalStatus:\s*"draft"[\s\S]*sendStatus:\s*"not_sent"/,
"New generated outreach records should start as unsent drafts.",
);
});
test("sensitive public outreach exports require operators and validate references", () => {
const createSource = extractExportSource("create");
const listSource = extractExportSource("list");
hasPattern(createSource, /requireOperator\(ctx\)/, "create should require operator auth.");
hasPattern(listSource, /requireOperator\(ctx\)/, "list should require operator auth.");
hasPattern(createSource, /ctx\.db\.get\(args\.leadId\)/, "create should verify the lead exists.");
hasPattern(createSource, /!lead/, "create should reject missing leads.");
hasPattern(createSource, /ctx\.db\.get\(args\.auditId\)/, "create should load provided audits.");
hasPattern(createSource, /!audit/, "create should reject missing audits.");
hasPattern(
createSource,
/audit\.leadId\s*!==\s*args\.leadId/,
"create should reject auditId values that belong to a different lead.",
);
});
test("saveReviewDraft validates editable fields and never edits sent records", () => {
const saveSource = extractExportSource("saveReviewDraft");
hasPattern(outreachSource, /export const saveReviewDraft = mutation\(/, "saveReviewDraft should be a mutation.");
hasPattern(saveSource, /requireOperator\(ctx\)/, "saveReviewDraft should require auth.");
hasPattern(saveSource, /id:\s*v\.id\("outreachRecords"\)/, "saveReviewDraft should validate the outreach id.");
hasPattern(saveSource, /strategy:\s*strategy/, "saveReviewDraft should validate strategy with the shared strategy validator.");
for (const fieldName of [
"phoneScript",
"emailSubject",
"emailBody",
"followUpDraft",
]) {
hasPattern(
saveSource,
new RegExp(`${fieldName}:\\s*v\\.optional\\(v\\.string\\(\\)\\)`),
`${fieldName} should be optional editable copy.`,
);
}
hasPattern(saveSource, /ctx\.db\.get\(args\.id\)/, "saveReviewDraft should load the outreach record.");
hasPattern(saveSource, /!outreach/, "saveReviewDraft should reject missing outreach.");
hasPattern(saveSource, /outreach\.sendStatus\s*===\s*"sent"/, "saveReviewDraft should reject sent outreach records.");
hasPattern(saveSource, /outreach\.sendStatus\s*===\s*"queued"/, "saveReviewDraft should reject queued outreach records.");
hasPattern(saveSource, /approvalStatus:\s*"draft"/, "Saving edits should reset approval to draft.");
hasPattern(saveSource, /updatedAt:\s*now/, "Saving edits should stamp updatedAt.");
hasPattern(saveSource, /ctx\.db\.patch\(args\.id/, "saveReviewDraft should patch the existing outreach record.");
});
test("approveEmailDraft validates approval prerequisites and preserves send separation", () => {
const approveSource = extractExportSource("approveEmailDraft");
hasPattern(outreachSource, /export const approveEmailDraft = mutation\(/, "approveEmailDraft should be a mutation.");
hasPattern(approveSource, /requireOperator\(ctx\)/, "approveEmailDraft should require auth.");
hasPattern(approveSource, /id:\s*v\.id\("outreachRecords"\)/, "approveEmailDraft should validate the outreach id.");
hasPattern(approveSource, /ctx\.db\.get\(args\.id\)/, "approveEmailDraft should load the outreach record.");
hasPattern(approveSource, /!outreach/, "approveEmailDraft should reject missing outreach.");
hasPattern(approveSource, /outreach\.sendStatus\s*===\s*"sent"/, "approveEmailDraft should reject sent outreach records.");
hasPattern(
approveSource,
/outreach\.sendStatus\s*===\s*"queued"/,
"approveEmailDraft should reject queued outreach records.",
);
hasPattern(approveSource, /ctx\.db\.get\(outreach\.leadId\)/, "approveEmailDraft should load the linked lead.");
hasPattern(approveSource, /lead\.email\?\.trim\(\)/, "approveEmailDraft should require a trimmed recipient email.");
hasPattern(approveSource, /outreach\.emailSubject\?\.trim\(\)/, "approveEmailDraft should require a trimmed subject.");
hasPattern(approveSource, /outreach\.emailBody\?\.trim\(\)/, "approveEmailDraft should require a trimmed body.");
hasPattern(
approveSource,
/process\.env\.SMTP_FROM\?\.trim\(\)/,
"approveEmailDraft should resolve the configured SMTP_FROM sender.",
);
hasPattern(
approveSource,
/SMTP-Absender-Adresse fehlt\./,
"approveEmailDraft should fail fast if SMTP_FROM is not configured.",
);
hasPattern(approveSource, /approvalStatus:\s*"approved"/, "Approval should mark only the approval status.");
hasPattern(approveSource, /updatedAt:\s*now/, "Approval should stamp updatedAt.");
hasPattern(approveSource, /recipient:/, "Approval should return recipient context.");
hasPattern(approveSource, /subject:/, "Approval should return subject context.");
hasPattern(approveSource, /sender:/, "Approval should return sender context.");
hasPattern(approveSource, /auditSlug:/, "Approval should return audit slug context when available.");
lacksPattern(approveSource, /sendStatus\s*:/, "Approval must not alter sendStatus.");
lacksPattern(
approveSource,
/SMTP_USER|SMTP_PASSWORD|SMTP_HOST/,
"Approval should not expose SMTP credentials in returned context.",
);
lacksPattern(
approveSource,
/ctx\.scheduler|runAfter|runMutation|nodemailer|smpp|sendEmail/i,
"Approval must not queue or send email/SMPP/Nodemailer work.",
);
});
test("schema defines outbound send attempt logging table", () => {
assert.equal(existsSync(schemaPath), true, "schema.ts should be present.");
const tableSource = extractTableSource("outreachSendAttempts");
assert.equal(
tableSource.length > 0,
true,
"schema.ts should define outreachSendAttempts table.",
);
hasPattern(
tableSource,
/outreachId:\s*v\.id\(\s*"outreachRecords"\s*\)/,
"outreachSendAttempts must track outreachId.",
);
hasPattern(
tableSource,
/leadId:\s*v\.id\(\s*"leads"\s*\)/,
"outreachSendAttempts must track leadId.",
);
hasPattern(
tableSource,
/auditId:\s*v\.optional\(v\.id\(\s*"audits"\s*\)\)/,
"outreachSendAttempts should optionally track auditId.",
);
hasPattern(
tableSource,
/recipient:\s*v\.string\(\)/,
"outreachSendAttempts should persist recipient.",
);
hasPattern(
tableSource,
/subject:\s*v\.string\(\)/,
"outreachSendAttempts should persist subject.",
);
hasPattern(
tableSource,
/body:\s*v\.string\(\)/,
"outreachSendAttempts should persist body.",
);
hasPattern(
tableSource,
/sender:\s*v\.string\(\)/,
"outreachSendAttempts should persist sender.",
);
hasPattern(
tableSource,
/status:\s*(?:v\.union\(\s*v\.literal\(\s*"success"\s*\),\s*v\.literal\(\s*"failed"\s*\)\s*\)|outreachSendAttemptStatus)/,
"outreachSendAttempts status must be success or failed.",
);
hasPattern(
tableSource,
/sentAt:\s*v\.optional\(v\.number\(\)\)/,
"outreachSendAttempts should persist optional sentAt.",
);
hasPattern(
tableSource,
/smtpMessageId:\s*v\.optional\(v\.string\(\)\)/,
"outreachSendAttempts should persist optional smtpMessageId.",
);
hasPattern(
tableSource,
/smtpResponse:\s*v\.optional\(v\.string\(\)\)/,
"outreachSendAttempts should persist optional smtpResponse.",
);
hasPattern(
tableSource,
/smtpAccepted:\s*v\.optional\(v\.array\(v\.string\(\)\)\)/,
"outreachSendAttempts should persist optional smtpAccepted.",
);
hasPattern(
tableSource,
/smtpRejected:\s*v\.optional\(v\.array\(v\.string\(\)\)\)/,
"outreachSendAttempts should persist optional smtpRejected.",
);
hasPattern(
tableSource,
/errorMessage:\s*v\.optional\(v\.string\(\)\)/,
"outreachSendAttempts should persist optional errorMessage.",
);
hasPattern(
tableSource,
/errorCode:\s*v\.optional\(v\.string\(\)\)/,
"outreachSendAttempts should persist optional errorCode.",
);
hasPattern(
tableSource,
/errorResponseCode:\s*v\.optional\(v\.number\(\)\)/,
"outreachSendAttempts should persist optional errorResponseCode.",
);
hasPattern(
tableSource,
/errorResponse:\s*v\.optional\(v\.string\(\)\)/,
"outreachSendAttempts should persist optional errorResponse.",
);
hasPattern(
tableSource,
/auditLink:\s*v\.optional\(v\.union\(v\.string\(\),\s*v\.null\(\)\)\)/,
"outreachSendAttempts should persist optional auditLink.",
);
hasPattern(
tableSource,
/createdAt:\s*v\.number\(\)/,
"outreachSendAttempts should persist createdAt.",
);
hasPattern(
tableSource,
/updatedAt:\s*v\.number\(\)/,
"outreachSendAttempts should persist updatedAt.",
);
hasPattern(
schemaSource,
/defineTable\(\{\s*[\s\S]*\}\)\s*\.index\("by_outreachId",\s*\["outreachId"\]\)/,
"outreachSendAttempts should be queryable by outreach id.",
);
hasPattern(
schemaSource,
/"by_status",\s*\["status"\]/,
"outreachSendAttempts should include status indexing.",
);
});
test("outreach module exports internal send claim and logging mutations", () => {
const exports = getExportedConstNames(sourceFile);
for (const exportName of [
"claimApprovedEmailForSend",
"recordEmailSendSuccess",
"recordEmailSendFailure",
]) {
assert.equal(
exports.has(exportName),
true,
`Expected export: ${exportName}`,
);
}
const claimSource = extractExportSource("claimApprovedEmailForSend");
const successSource = extractExportSource("recordEmailSendSuccess");
const failureSource = extractExportSource("recordEmailSendFailure");
hasPattern(
claimSource,
/outreach\.approvalStatus\s*!==\s*"approved"/,
"claimApprovedEmailForSend must reject non-approved or already sent outreach records.",
);
hasPattern(
claimSource,
/outreach\.sendStatus\s*===\s*"sent"\s*\|\|\s*outreach\.sendStatus\s*===\s*"queued"/,
"claimApprovedEmailForSend should only claim not_sent or failed records.",
);
hasPattern(
claimSource,
/ctx\.db\.patch\(args\.id,\s*{[\s\S]*sendStatus:\s*"queued"[\s\S]*updatedAt:\s*now[\s\S]*}\)/,
"claimApprovedEmailForSend must set sendStatus queued and update updatedAt.",
);
hasPattern(
claimSource,
/sender/,
"claimApprovedEmailForSend should include sender in its snapshot return.",
);
hasPattern(
claimSource,
/recipient/,
"claimApprovedEmailForSend should include recipient in its snapshot return.",
);
hasPattern(
claimSource,
/body/,
"claimApprovedEmailForSend should include body in its snapshot return.",
);
hasPattern(
claimSource,
/auditLink/,
"claimApprovedEmailForSend should include optional auditLink in its snapshot return.",
);
hasPattern(
successSource,
/ctx\.db\.patch\(args\.id,\s*{[\s\S]*sendStatus:\s*"sent"[\s\S]*sentAt:\s*args\.sentAt[\s\S]*updatedAt:\s*now[\s\S]*}\)/,
"recordEmailSendSuccess should mark status sent, sentAt, and updatedAt.",
);
hasPattern(
successSource,
/ctx\.db\.patch\(lead\._id,[\s\S]*contactStatus:\s*"contacted"[\s\S]*updatedAt:\s*now[\s\S]*}\)/,
"recordEmailSendSuccess should mark outreach lead as contacted.",
);
hasPattern(
successSource,
/ctx\.db\.insert\(\s*"outreachSendAttempts"/,
"recordEmailSendSuccess should insert an outreachSendAttempts row.",
);
hasPattern(
failureSource,
/ctx\.db\.patch\(args\.id,\s*{[\s\S]*sendStatus:\s*"failed"[\s\S]*updatedAt:\s*now[\s\S]*}\)/,
"recordEmailSendFailure should mark status failed and update updatedAt.",
);
hasPattern(
failureSource,
/ctx\.db\.insert\(\s*"outreachSendAttempts"/,
"recordEmailSendFailure should insert an outreachSendAttempts row.",
);
hasPattern(
successSource,
/status:\s*outreachSendAttemptSuccessStatus/,
"recordEmailSendSuccess should send a typed success status.",
);
hasPattern(
failureSource,
/status:\s*outreachSendAttemptFailedStatus/,
"recordEmailSendFailure should send a typed failed status.",
);
lacksPattern(
failureSource,
/contactStatus:\s*"contacted"/,
"recordEmailSendFailure should not update lead to contacted.",
);
});
test("outreachSendAction exists as Node action and orchestrates claim/send/log flow", () => {
assert.equal(existsSync(actionPath), true, "outreachSendAction.ts should be present.");
const actionExports = getExportedConstNames(actionSourceFile);
hasPattern(
outreachSendActionSource,
/^"use node";/m,
"outreachSendAction.ts should declare Node runtime.",
);
assert.equal(
actionExports.has("sendApprovedEmail"),
true,
"outreachSendAction.ts should export sendApprovedEmail.",
);
hasPattern(
outreachSendActionSource,
/sendApprovedEmail\s*=\s*action\(\s*{\s*args:\s*{[\s\S]*id:\s*v\.id\(\s*"outreachRecords"\s*\)[\s\S]*}\s*,/,
"sendApprovedEmail should accept outreachRecords id.",
);
hasPattern(
outreachSendActionSource,
/internal\.outreach\.claimApprovedEmailForSend/,
"sendApprovedEmail must call claimApprovedEmailForSend before sending.",
);
hasPattern(
outreachSendActionSource,
/nodemailer\.createTransport\(\s*{[\s\S]*host:\s*smtpHost[\s\S]*port:\s*smtpPort[\s\S]*secure:\s*isSecureSmtp/,
"sendApprovedEmail should configure Nodemailer from SMTP env vars.",
);
hasPattern(
outreachSendActionSource,
/sendMail\(\s*{[\s\S]*from:\s*snapshot\.sender[\s\S]*to:\s*snapshot\.recipient[\s\S]*subject:\s*snapshot\.subject[\s\S]*text:\s*snapshot\.body[\s\S]*}\s*\)/,
"sendApprovedEmail should send with snapshot sender, recipient, subject, body.",
);
hasPattern(
outreachSendActionSource,
/internal\.outreach\.recordEmailSendSuccess/,
"sendApprovedEmail should delegate successful sends to recordEmailSendSuccess.",
);
hasPattern(
outreachSendActionSource,
/internal\.outreach\.recordEmailSendFailure/,
"sendApprovedEmail should delegate failed sends to recordEmailSendFailure.",
);
hasPattern(
outreachSendActionSource,
/console\.error\(|console\.warn\(/,
"sendApprovedEmail should log failed sends with a concrete error path.",
);
hasPattern(
outreachSendActionSource,
/sanitizeSmtpError/,
"sendApprovedEmail should sanitize SMTP error details before logging.",
);
hasPattern(
outreachSendActionSource,
/const successPayload: \{[\s\S]*auditId\?:[\s\S]*auditLink\?:[\s\S]*smtpMessageId\?:[\s\S]*smtpAccepted\?:[\s\S]*smtpRejected\?:/,
"Success logging payload should be assembled with optional fields, not spread directly.",
);
hasPattern(
outreachSendActionSource,
/const failurePayload: \{[\s\S]*auditId\?:[\s\S]*auditLink\?:[\s\S]*errorMessage\?:[\s\S]*errorCode\?:[\s\S]*errorResponseCode\?:[\s\S]*errorResponse\?:/,
"Failure logging payload should be assembled with optional fields, not spread directly.",
);
});

View File

@@ -0,0 +1,309 @@
import assert from "node:assert/strict";
import { readFile } from "node:fs/promises";
import { join } from "node:path";
import test from "node:test";
const outreachPagePath = join(
process.cwd(),
"app",
"dashboard",
"outreach",
"page.tsx",
);
const outreachWorkspacePath = join(
process.cwd(),
"components",
"outreach",
"outreach-review-workspace.tsx",
);
function extractConstFunction(source: string, name: string) {
const declaration = new RegExp(`const ${name}\\s*=\\s*(?:async\\s+)?\\(`);
const match = source.match(declaration);
assert.ok(match, `${name} handler should exist.`);
const start = match.index ?? -1;
assert.ok(start >= 0, `${name} handler should exist.`);
const firstBrace = source.indexOf("{", start);
assert.ok(firstBrace >= 0, `${name} handler should have a body.`);
let depth = 0;
for (let index = firstBrace; index < source.length; index += 1) {
const char = source[index];
if (char === "{") {
depth += 1;
}
if (char === "}") {
depth -= 1;
if (depth === 0) {
return source.slice(start, index + 1);
}
}
}
assert.fail(`${name} handler body should close.`);
}
test("/dashboard/outreach mounts the outreach review workspace", async () => {
const source = await readFile(outreachPagePath, "utf8");
assert.doesNotMatch(source, /DashboardPlaceholderPage/);
assert.match(source, /OutreachReviewWorkspace/);
assert.match(
source,
/@\/components\/outreach\/outreach-review-workspace/,
);
});
test("OutreachReviewWorkspace uses the review workspace API and required controls", async () => {
const source = await readFile(outreachWorkspacePath, "utf8");
assert.match(source, /api\.outreach(?:\s+as\s+OutreachApi\))?\.listReviewWorkspace/);
assert.match(source, /limit:\s*100/);
assert.match(source, /api\.outreach(?:\s+as\s+OutreachApi\))?\.saveReviewDraft/);
assert.match(source, /api\.outreach(?:\s+as\s+OutreachApi\))?\.approveEmailDraft/);
assert.match(source, /api\.audits\.savePublicAuditContent/);
assert.match(source, /api\.audits\.publishPublicAudit/);
[
"Lead-Details",
"Kontaktquellen",
"Prioritätsgrund",
"Kontaktstrategie",
"Audit-Zusammenfassung",
"Public-Audit",
"Verwendete Skills",
"Quellen anzeigen",
"Raw anzeigen",
"E-Mail-Betreff",
"E-Mail-Text",
"Telefon-Skript",
"Follow-up-Draft",
].forEach((label) => assert.match(source, new RegExp(label)));
});
test("OutreachReviewWorkspace keeps exactly one recommended email subject and body editor", async () => {
const source = await readFile(outreachWorkspacePath, "utf8");
assert.equal((source.match(/aria-label="E-Mail-Betreff"/g) ?? []).length, 1);
assert.equal((source.match(/aria-label="E-Mail-Text"/g) ?? []).length, 1);
assert.equal((source.match(/<Input\b/g) ?? []).length, 1);
assert.doesNotMatch(source, /Version\s*[23]|Alternative|Variante/);
});
test("OutreachReviewWorkspace separates audit publication from email approval", async () => {
const source = await readFile(outreachWorkspacePath, "utf8");
assert.match(source, /Audit veröffentlichen/);
assert.match(source, /Änderungen speichern/);
assert.match(source, /E-Mail freigeben und senden/);
assert.match(source, /useAction/);
assert.match(source, /outreachSendAction[\s\S]*sendApprovedEmail/);
const auditPublishIndex = source.indexOf("Audit veröffentlichen");
const auditSaveIndex = source.indexOf("Änderungen speichern");
const emailApprovalIndex = source.indexOf("E-Mail freigeben und senden");
assert.ok(auditPublishIndex >= 0);
assert.ok(auditSaveIndex >= 0);
assert.ok(emailApprovalIndex >= 0);
assert.ok(
Math.abs(auditPublishIndex - auditSaveIndex) <
Math.abs(auditPublishIndex - emailApprovalIndex),
"Audit actions should be grouped closer to each other than to email approval.",
);
});
test("OutreachReviewWorkspace disables draft/approval/final controls for queued send", async () => {
const source = await readFile(outreachWorkspacePath, "utf8");
assert.match(source, /outreach\.sendStatus\s*===\s*"queued"/);
assert.match(source, /const isQueuedSend = outreach\?\.sendStatus === "queued"/);
assert.match(
source,
/disabled=\{[\s\S]*busyAction === `\$?\{record\.id\}:outreach-save`[\s\S]*\|\|\s*isQueuedSend[\s\S]*\}/,
"Outreach save control should be disabled while outreach is queued.",
);
assert.match(
source,
/disabled=\{[\s\S]*busyAction === `\$?\{record\.id\}:email-approval`[\s\S]*\|\|\s*isQueuedSend[\s\S]*\}/,
"Email approval control should be disabled while outreach is queued.",
);
assert.match(
source,
/disabled=\{[\s\S]*busyAction === `\$?\{pendingEmailConfirmation\.id\}:email-send`[\s\S]*\|\|\s*isQueuedSendForConfirmation[\s\S]*\}/,
"Final send control should be disabled while confirmed outreach is queued.",
);
});
test("OutreachReviewWorkspace prevents draft mutation handlers for queued outreach", async () => {
const source = await readFile(outreachWorkspacePath, "utf8");
const saveOutreachHandler = extractConstFunction(source, "saveOutreach");
const approveEmailHandler = extractConstFunction(source, "approveEmail");
assert.match(saveOutreachHandler, /outreach\.sendStatus\s*===\s*"queued"/);
assert.match(saveOutreachHandler, /[aA]ufgrund des laufenden Sendevorgangs/);
assert.match(approveEmailHandler, /outreach\.sendStatus\s*===\s*"queued"/);
assert.match(approveEmailHandler, /[aA]ufgrund des laufenden Sendevorgangs/);
});
test("OutreachReviewWorkspace prevents final send when confirmed outreach is queued", async () => {
const source = await readFile(outreachWorkspacePath, "utf8");
const sendHandler = extractConstFunction(source, "sendApprovedEmailFromConfirmation");
assert.match(
sendHandler,
/const isQueuedSend = rows\.some\(/,
"Final send handler should check current list records for queued status before sending.",
);
assert.match(
sendHandler,
/\.sendStatus\s*===\s*"queued"/,
"Final send handler should guard queued status.",
);
assert.match(
sendHandler,
/setNotice\(\s*"(?:.*(?:[aA]ufgrund[^"\r\n]*Sendevorgang|.*bereits[^"\r\n]*Vorgang|.*bereits[^"\r\n]*im Gange)[^"]*)"/,
);
});
test("OutreachReviewWorkspace useAction receives a typed send action ref", async () => {
const source = await readFile(outreachWorkspacePath, "utf8");
assert.match(source, /useAction\(api\.outreachSendAction\.sendApprovedEmail\)/);
assert.doesNotMatch(
source,
/as \{\s*outreachSendAction:\s*\{\s*sendApprovedEmail:\s*unknown/,
);
});
test("OutreachReviewWorkspace includes final confirmation UI fields", async () => {
const source = await readFile(outreachWorkspacePath, "utf8");
assert.match(source, /Dialog/);
assert.match(source, /Empfänger/);
assert.match(source, /Betreff/);
assert.match(source, /Absender/);
assert.match(source, /Audit-Link/);
assert.match(source, /sender/);
assert.doesNotMatch(source, /Konfigurierter SMTP-Absender/);
});
test("approveEmail opens confirmation after save and approval", async () => {
const source = await readFile(outreachWorkspacePath, "utf8");
const handler = extractConstFunction(source, "approveEmail");
const draftIndex = handler.indexOf("const draft = drafts[record.id] ?? getDraft(record)");
const saveIndex = handler.indexOf("await saveReviewDraft");
const approveIndex = handler.indexOf("await approveEmailDraft");
const confirmationIndex = handler.indexOf("setPendingEmailConfirmation");
assert.ok(draftIndex >= 0, "Approval should read the current local draft.");
assert.ok(saveIndex >= 0, "Approval should persist the current draft first.");
assert.ok(approveIndex >= 0, "Approval should still call approveEmailDraft.");
assert.ok(confirmationIndex >= 0, "Approval should open a confirmation dialog.");
assert.ok(draftIndex < saveIndex, "Approval should read draft before save.");
assert.ok(saveIndex < approveIndex, "Approval should save before approve.");
assert.ok(approveIndex < confirmationIndex, "Confirmation should open after approval.");
assert.equal(
/sendApprovedEmail/.test(handler),
false,
"Approval should not call sendApprovedEmail.",
);
assert.match(handler, /emailSubject:\s*draft\.emailSubject/);
assert.match(handler, /emailBody:\s*draft\.emailBody/);
assert.match(handler, /followUpDraft:\s*draft\.followUpDraft/);
assert.match(
handler,
/approvalData\.sender/,
);
assert.ok(
!/approvalData\.sender\s*\?\?\s*SMTP_SENDER_PLACEHOLDER/.test(handler),
"Sender should come from approvalResult without placeholder fallback.",
);
});
test("OutreachReviewWorkspace gates phone scripts to call-first or missing-contact leads with phone numbers", async () => {
const source = await readFile(outreachWorkspacePath, "utf8");
assert.match(source, /hasCallablePhone/);
assert.match(source, /strategy\s*===\s*"call_first"/);
assert.match(source, /lead\?\.contactStatus\s*===\s*"missing_contact"/);
assert.match(source, /Kein Telefon-Skript erforderlich/);
});
test("approveEmail saves the visible outreach draft before approving it", async () => {
const source = await readFile(outreachWorkspacePath, "utf8");
const handler = extractConstFunction(source, "approveEmail");
const draftIndex = handler.indexOf("const draft = drafts[record.id] ?? getDraft(record)");
const saveIndex = handler.indexOf("await saveReviewDraft");
const approveIndex = handler.indexOf("await approveEmailDraft");
assert.ok(draftIndex >= 0, "Approval should read the current local draft.");
assert.ok(saveIndex >= 0, "Approval should persist the current draft first.");
assert.ok(approveIndex >= 0, "Approval should still call approveEmailDraft.");
assert.ok(
draftIndex < saveIndex && saveIndex < approveIndex,
"Approval should read draft, save it, then approve.",
);
assert.match(handler, /emailSubject:\s*draft\.emailSubject/);
assert.match(handler, /emailBody:\s*draft\.emailBody/);
assert.match(handler, /followUpDraft:\s*draft\.followUpDraft/);
});
test("final email send handler calls sendApprovedEmail with outreach id", async () => {
const source = await readFile(outreachWorkspacePath, "utf8");
const handler = extractConstFunction(source, "sendApprovedEmailFromConfirmation");
assert.match(handler, /await sendApprovedEmail\(\{\s*id:\s*confirmation\.id/);
assert.ok(
/await sendApprovedEmail\([\s\S]*id:\s*confirmation\.id[\s\S]*\}/.test(handler),
"Final handler should pass the currently confirmed outreach id.",
);
assert.ok(
handler.indexOf("E-Mail gesendet.") >= 0,
"Final send should show a success notice.",
);
assert.ok(
/Retry|erneut|nochmal|nicht versendet|nicht gesendet/.test(handler),
"Final send should surface a retry-oriented failure notice.",
);
assert.equal(
handler.indexOf("setPendingEmailConfirmation(null)") >= 0,
true,
"Final handler should clear confirmation on success.",
);
});
test("canceling confirmation does not send", async () => {
const source = await readFile(outreachWorkspacePath, "utf8");
const handler = extractConstFunction(source, "closeEmailConfirmation");
assert.ok(handler.includes("setPendingEmailConfirmation(null)"));
assert.equal(/sendApprovedEmail/.test(handler), false);
});
test("publishAudit saves the visible audit draft before publishing it", async () => {
const source = await readFile(outreachWorkspacePath, "utf8");
const handler = extractConstFunction(source, "publishAudit");
const draftIndex = handler.indexOf("const draft = drafts[record.id] ?? getDraft(record)");
const saveIndex = handler.indexOf("await savePublicAuditContent");
const publishIndex = handler.indexOf("await publishPublicAudit");
assert.ok(draftIndex >= 0, "Publishing should read the current local audit draft.");
assert.ok(saveIndex >= 0, "Publishing should save the public audit content first.");
assert.ok(publishIndex >= 0, "Publishing should still call publishPublicAudit.");
assert.ok(
draftIndex < saveIndex && saveIndex < publishIndex,
"Publishing should read draft, save it, then publish.",
);
assert.match(handler, /publicSummary:\s*draft\.auditSummary/);
assert.match(handler, /publicBody:\s*draft\.auditBody/);
});