matthias/pitchfast
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix MVP audit evidence pipeline

Browse Source
This commit is contained in:
Matthias Meister
2026-06-08 08:33:15 +02:00
parent a45b92ea0a
commit ff18fc202e
16 changed files with 771 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

46
backlog/tasks/task-44 - Port-audit-pipeline-fully-into-the-MVP.md Normal file
View File

@@ -0,0 +1,46 @@
---
id: TASK-44
title: Port audit pipeline fully into the MVP
status: In Progress
assignee: []
created_date: '2026-06-07 21:16'
updated_date: '2026-06-07 21:34'
labels: []
dependencies: []
priority: high
ordinal: 46000
---
## Description
<!-- SECTION:DESCRIPTION:BEGIN -->
Remove runtime dependencies on v2 reference files, bundle the v3 audit skill registry into the MVP, and ensure audit generation consumes website enrichment evidence from the lead's latest successful enrichment run.
<!-- SECTION:DESCRIPTION:END -->
## Acceptance Criteria
<!-- AC:BEGIN -->
- [x] #1 Audit generation no longer reads or imports v2_elemente at runtime
- [x] #2 MVP v3 audit skills are bundled through a production-owned source and selected during audit evidence building
- [x] #3 Audit generation evidence includes crawl pages, technical checks, and screenshots from the latest successful website_enrichment run for the same lead
- [ ] #4 ScreenshotOne remains optional only until configured and no missing-key warning appears after the corrected Convex env is present
- [x] #5 Regression tests and local verification commands pass
<!-- AC:END -->
## Implementation Plan
<!-- SECTION:PLAN:BEGIN -->
1. Add RED tests for bundled MVP skill registry and no v2 runtime dependency
2. Add RED tests for audit evidence loading latest successful website enrichment data by lead
3. Implement bundled MVP v3 skill registry and wire audit generation action to it
4. Implement lead-based enrichment evidence lookup with audit-run screenshot fallback
5. Clarify readiness copy for Next vs Convex env scope
6. Run focused and full verification without closing the backlog task
<!-- SECTION:PLAN:END -->
## Implementation Notes
<!-- SECTION:NOTES:BEGIN -->
Implemented GREEN slice after RED tests: added bundled MVP v3 audit skill registry, rewired auditGenerationAction away from v2_elemente runtime file reads, loaded latest successful website_enrichment evidence by lead in getAuditGenerationEvidence, preserved audit-run ScreenshotOne captures, and clarified settings readiness copy for Next.js vs Convex Action env scope. Focused tests passed for registry, audit evidence, action source, persistence source, and ops quality.
Masked Convex env check confirms SCREENSHOTONE_API_KEY is present in the dev deployment. AC #4 remains open until a fresh live audit run confirms no ScreenshotOne missing-key warning in Run Events.
<!-- SECTION:NOTES:END -->

43
backlog/tasks/task-45 - Show-audit-evidence-on-detail-pages.md Normal file
View File

@@ -0,0 +1,43 @@
---
id: TASK-45
title: Show audit evidence on detail pages
status: In Progress
assignee: []
created_date: '2026-06-07 21:50'
updated_date: '2026-06-07 22:01'
labels: []
dependencies: []
priority: high
ordinal: 47000
---
## Description
<!-- SECTION:DESCRIPTION:BEGIN -->
Fix the audit detail view so stored checked pages and compact website-enrichment evidence are visible instead of only showing the page count.
<!-- SECTION:DESCRIPTION:END -->
## Acceptance Criteria
<!-- AC:BEGIN -->
- [x] #1 Audit detail query returns ordered checked-page evidence with crawl, technical, and screenshot summaries
- [x] #2 Audit detail UI renders a compact Geprüfte Seiten section between overview and skills
- [x] #3 Fallback rows render checkedPages even when enrichment evidence is missing
- [x] #4 Public audit and outreach flows remain unchanged
- [x] #5 Regression tests and local verification pass
<!-- AC:END -->
## Implementation Plan
<!-- SECTION:PLAN:BEGIN -->
1. Add RED tests for getDetail sourceSummaries checked-page evidence
2. Add RED tests for AuditDetail compact evidence rendering
3. Extend audits.getDetail with bounded lead/enrichment evidence summaries
4. Render compact checked-page evidence card in AuditDetail
5. Run focused and full verification without closing the task
<!-- SECTION:PLAN:END -->
## Implementation Notes
<!-- SECTION:NOTES:BEGIN -->
Implemented getDetail sourceSummaries.checkedPages with latest successful website_enrichment evidence by lead, bounded crawl/technical/screenshot joins, storage URL resolution, and checkedPages fallback rows. AuditDetail now renders a compact Geprüfte Seiten card between overview and skills. Verification passed: focused tests, pnpm test, app tsc, lint, git diff --check, convex codegen dry-run/typecheck, and convex dev --once. Browser plugin reached login because its session is unauthenticated; Arc/local authenticated session should show the deployed query after reload.
<!-- SECTION:NOTES:END -->