matthias/lemonspace_app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(tool-ui): remove render-time ref mutation in controllable state

Browse Source
This commit is contained in:
Matthias Meister
2026-04-03 18:02:44 +02:00
parent 16f24991a4
commit c33e65b0f6
1 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/components/tool-ui/shared/use-controllable-state.ts
View File

@@ -1,6 +1,6 @@
"use client"; "use client";
import { useCallback, useMemo, useRef, useState } from "react"; import { useCallback, useMemo, useState } from "react";
export type UseControllableStateOptions<T> = { export type UseControllableStateOptions<T> = {
value?: T; value?: T;
@@ -20,17 +20,14 @@ export function useControllableState<T>({
() => (isControlled ? (value as T) : uncontrolled), () => (isControlled ? (value as T) : uncontrolled),
[isControlled, value, uncontrolled], [isControlled, value, uncontrolled],
); );
const currentValueRef = useRef(currentValue);
currentValueRef.current = currentValue;
const setValue = useCallback( const setValue = useCallback(
(next: T | ((prev: T) => T)) => { (next: T | ((prev: T) => T)) => {
const resolved = const resolved =
typeof next === "function" typeof next === "function"
? (next as (prev: T) => T)(currentValueRef.current) ? (next as (prev: T) => T)(currentValue)
: next; : next;
currentValueRef.current = resolved;
if (!isControlled) { if (!isControlled) {
setUncontrolled(resolved); setUncontrolled(resolved);
} }
@@ -38,7 +35,7 @@ export function useControllableState<T>({
onChange?.(resolved); onChange?.(resolved);
return resolved; return resolved;
}, },
[isControlled, onChange], [currentValue, isControlled, onChange],
); );
const setUncontrolledValue = useCallback((next: T) => { const setUncontrolledValue = useCallback((next: T) => {