Add safe chat reasoning disclosure
This commit is contained in:
@@ -4,7 +4,7 @@ title: Modernize savings chat agent UI with AI Elements phases
|
|||||||
status: In Progress
|
status: In Progress
|
||||||
assignee: []
|
assignee: []
|
||||||
created_date: '2026-06-16 08:38'
|
created_date: '2026-06-16 08:38'
|
||||||
updated_date: '2026-06-16 08:41'
|
updated_date: '2026-06-16 08:46'
|
||||||
labels: []
|
labels: []
|
||||||
dependencies: []
|
dependencies: []
|
||||||
priority: high
|
priority: high
|
||||||
@@ -20,7 +20,7 @@ Implement the planned AI Elements-inspired savings chat agent UI in three sequen
|
|||||||
## Acceptance Criteria
|
## Acceptance Criteria
|
||||||
<!-- AC:BEGIN -->
|
<!-- AC:BEGIN -->
|
||||||
- [x] #1 Phase 1 replaces the basic chat surface with reusable conversation, message, prompt input, and tool trace UI primitives
|
- [x] #1 Phase 1 replaces the basic chat surface with reusable conversation, message, prompt input, and tool trace UI primitives
|
||||||
- [ ] #2 Phase 2 adds a safe reasoning/work-progress disclosure derived from existing tool traces, without exposing hidden chain-of-thought
|
- [x] #2 Phase 2 adds a safe reasoning/work-progress disclosure derived from existing tool traces, without exposing hidden chain-of-thought
|
||||||
- [ ] #3 Phase 3 adds structured source/citation support through stored assistant metadata and visible UI affordances
|
- [ ] #3 Phase 3 adds structured source/citation support through stored assistant metadata and visible UI affordances
|
||||||
- [ ] #4 Each phase is covered by failing-first tests, verified after implementation, and committed separately
|
- [ ] #4 Each phase is covered by failing-first tests, verified after implementation, and committed separately
|
||||||
<!-- AC:END -->
|
<!-- AC:END -->
|
||||||
@@ -41,4 +41,6 @@ Implement the planned AI Elements-inspired savings chat agent UI in three sequen
|
|||||||
|
|
||||||
<!-- SECTION:NOTES:BEGIN -->
|
<!-- SECTION:NOTES:BEGIN -->
|
||||||
Phase 1 complete: added AgentChat primitives for conversation, message rendering, prompt input, and tool trace disclosure; integrated SavingsChatPage. Verification: npx vitest src/components/chat/AgentChat.test.tsx --run, npx eslint targeted chat/page files, npm run build (Vite chunk-size warning only).
|
Phase 1 complete: added AgentChat primitives for conversation, message rendering, prompt input, and tool trace disclosure; integrated SavingsChatPage. Verification: npx vitest src/components/chat/AgentChat.test.tsx --run, npx eslint targeted chat/page files, npm run build (Vite chunk-size warning only).
|
||||||
|
|
||||||
|
Phase 2 complete locally: added safe work-progress/reasoning disclosure derived from toolTrace result summaries, removed raw inputSummary display from the disclosure, and added active progress state while a response is pending. Verification: npx vitest src/components/chat/AgentChat.test.tsx --run (9 tests), targeted eslint, npm run build (Vite chunk-size warning only). Spec subagent review approved.
|
||||||
<!-- SECTION:NOTES:END -->
|
<!-- SECTION:NOTES:END -->
|
||||||
|
|||||||
@@ -6,7 +6,7 @@ import {
|
|||||||
AgentPromptInput,
|
AgentPromptInput,
|
||||||
type AgentChatMessage,
|
type AgentChatMessage,
|
||||||
} from "./AgentChat";
|
} from "./AgentChat";
|
||||||
import { getToolTraceSummary } from "./agentChatModel";
|
import { buildReasoningSteps, getToolTraceSummary } from "./agentChatModel";
|
||||||
|
|
||||||
const assistantMessage: AgentChatMessage = {
|
const assistantMessage: AgentChatMessage = {
|
||||||
id: "assistant-1",
|
id: "assistant-1",
|
||||||
@@ -111,3 +111,40 @@ describe("AgentChat phase 1 components", () => {
|
|||||||
expect(markup).not.toContain("Werkzeuge verwendet");
|
expect(markup).not.toContain("Werkzeuge verwendet");
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe("AgentChat phase 2 reasoning disclosure", () => {
|
||||||
|
test("builds safe reasoning steps from tool traces without exposing raw inputs", () => {
|
||||||
|
const steps = buildReasoningSteps(assistantMessage.toolTrace);
|
||||||
|
|
||||||
|
expect(steps).toEqual([
|
||||||
|
{
|
||||||
|
label: "summarize_transactions",
|
||||||
|
description: "12 Umsaetze zusammengefasst",
|
||||||
|
status: "complete",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
label: "list_transactions",
|
||||||
|
description: "1 Treffer",
|
||||||
|
status: "complete",
|
||||||
|
},
|
||||||
|
]);
|
||||||
|
expect(JSON.stringify(steps)).not.toContain("Mai 2026");
|
||||||
|
});
|
||||||
|
|
||||||
|
test("renders an assistant work-progress disclosure from tool traces", () => {
|
||||||
|
const markup = renderToStaticMarkup(<AgentMessage message={assistantMessage} />);
|
||||||
|
|
||||||
|
expect(markup).toContain("So wurde gearbeitet");
|
||||||
|
expect(markup).toContain("summarize_transactions");
|
||||||
|
expect(markup).toContain("12 Umsaetze zusammengefasst");
|
||||||
|
});
|
||||||
|
|
||||||
|
test("marks the current agent step as active while submitting", () => {
|
||||||
|
const markup = renderToStaticMarkup(
|
||||||
|
<AgentConversation messages={[assistantMessage]} isSubmitting />,
|
||||||
|
);
|
||||||
|
|
||||||
|
expect(markup).toContain("Antwort wird vorbereitet");
|
||||||
|
expect(markup).toContain("data-status=\"active\"");
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|||||||
@@ -2,15 +2,16 @@ import {
|
|||||||
type ChangeEvent,
|
type ChangeEvent,
|
||||||
type FormEvent,
|
type FormEvent,
|
||||||
type HTMLAttributes,
|
type HTMLAttributes,
|
||||||
type ReactNode,
|
|
||||||
type Ref,
|
type Ref,
|
||||||
} from "react";
|
} from "react";
|
||||||
import { Loader2, Send, Wrench } from "lucide-react";
|
import { Loader2, Send, Wrench } from "lucide-react";
|
||||||
import { Button } from "@/components/ui/button";
|
import { Button } from "@/components/ui/button";
|
||||||
import { cn } from "@/lib/utils";
|
import { cn } from "@/lib/utils";
|
||||||
import {
|
import {
|
||||||
|
buildReasoningSteps,
|
||||||
getToolTraceSummary,
|
getToolTraceSummary,
|
||||||
type AgentChatMessage,
|
type AgentChatMessage,
|
||||||
|
type AgentReasoningStep,
|
||||||
type AgentToolTrace,
|
type AgentToolTrace,
|
||||||
} from "./agentChatModel";
|
} from "./agentChatModel";
|
||||||
export type { AgentChatMessage, AgentToolTrace } from "./agentChatModel";
|
export type { AgentChatMessage, AgentToolTrace } from "./agentChatModel";
|
||||||
@@ -89,39 +90,43 @@ export function AgentMessage({ message, className, ...props }: AgentMessageProps
|
|||||||
}
|
}
|
||||||
|
|
||||||
function AgentToolTracePanel({ toolTrace }: { toolTrace: AgentToolTrace[] }) {
|
function AgentToolTracePanel({ toolTrace }: { toolTrace: AgentToolTrace[] }) {
|
||||||
|
const steps = buildReasoningSteps(toolTrace);
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<details className="mt-3 rounded-md border bg-muted/30 px-2 py-1.5">
|
<details className="mt-3 rounded-md border bg-muted/30 px-2 py-1.5">
|
||||||
<summary className="flex cursor-pointer list-none items-center gap-2 text-xs font-medium text-muted-foreground">
|
<summary className="flex cursor-pointer list-none items-center gap-2 text-xs font-medium text-muted-foreground">
|
||||||
<Wrench className="h-3.5 w-3.5" />
|
<Wrench className="h-3.5 w-3.5" />
|
||||||
{getToolTraceSummary(toolTrace)}
|
So wurde gearbeitet ({getToolTraceSummary(toolTrace)})
|
||||||
</summary>
|
</summary>
|
||||||
<div className="mt-2 space-y-2">
|
<div className="mt-2 space-y-2">
|
||||||
{toolTrace.map((tool, toolIndex) => (
|
{steps.map((step, stepIndex) => (
|
||||||
<div key={`${tool.name}-${toolIndex}`} className="rounded-md bg-background/80 p-2 text-xs">
|
<ReasoningStep key={`${step.label}-${stepIndex}`} step={step} />
|
||||||
<p className="font-medium text-foreground">{tool.name}</p>
|
|
||||||
<ToolTraceLine label="Eingabe" value={tool.inputSummary} />
|
|
||||||
<ToolTraceLine label="Ergebnis" value={tool.resultSummary} />
|
|
||||||
</div>
|
|
||||||
))}
|
))}
|
||||||
</div>
|
</div>
|
||||||
</details>
|
</details>
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
function ToolTraceLine({ label, value }: { label: ReactNode; value: ReactNode }) {
|
function ReasoningStep({ step }: { step: AgentReasoningStep }) {
|
||||||
return (
|
return (
|
||||||
<p className="mt-1 text-muted-foreground">
|
<div className="rounded-md bg-background/80 p-2 text-xs" data-status={step.status}>
|
||||||
<span className="font-medium text-foreground">{label}: </span>
|
<p className="font-medium text-foreground">{step.label}</p>
|
||||||
{value}
|
<p className="mt-1 text-muted-foreground">{step.description}</p>
|
||||||
</p>
|
</div>
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
function AgentThinkingIndicator() {
|
function AgentThinkingIndicator() {
|
||||||
return (
|
return (
|
||||||
<div className="flex items-center gap-2 px-1 text-sm text-muted-foreground">
|
<div className="space-y-2 px-1 text-sm text-muted-foreground">
|
||||||
<Loader2 className="h-4 w-4 animate-spin" />
|
<div className="flex items-center gap-2">
|
||||||
Denk mit der KI nach...
|
<Loader2 className="h-4 w-4 animate-spin" />
|
||||||
|
Denk mit der KI nach...
|
||||||
|
</div>
|
||||||
|
<div className="rounded-md border bg-muted/30 p-2 text-xs" data-status="active">
|
||||||
|
<p className="font-medium text-foreground">Antwort wird vorbereitet</p>
|
||||||
|
<p className="mt-1">Der Agent prueft den aktuellen Finanzkontext.</p>
|
||||||
|
</div>
|
||||||
</div>
|
</div>
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -11,7 +11,23 @@ export type AgentChatMessage = {
|
|||||||
toolTrace?: AgentToolTrace[];
|
toolTrace?: AgentToolTrace[];
|
||||||
};
|
};
|
||||||
|
|
||||||
|
export type AgentReasoningStep = {
|
||||||
|
label: string;
|
||||||
|
description: string;
|
||||||
|
status: "complete" | "active" | "pending";
|
||||||
|
};
|
||||||
|
|
||||||
export function getToolTraceSummary(toolTrace: AgentToolTrace[] | undefined) {
|
export function getToolTraceSummary(toolTrace: AgentToolTrace[] | undefined) {
|
||||||
if (!toolTrace || toolTrace.length === 0) return "Keine Werkzeuge";
|
if (!toolTrace || toolTrace.length === 0) return "Keine Werkzeuge";
|
||||||
return `${toolTrace.length} ${toolTrace.length === 1 ? "Werkzeug" : "Werkzeuge"} verwendet`;
|
return `${toolTrace.length} ${toolTrace.length === 1 ? "Werkzeug" : "Werkzeuge"} verwendet`;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
export function buildReasoningSteps(toolTrace: AgentToolTrace[] | undefined): AgentReasoningStep[] {
|
||||||
|
if (!toolTrace || toolTrace.length === 0) return [];
|
||||||
|
|
||||||
|
return toolTrace.map((tool) => ({
|
||||||
|
label: tool.name,
|
||||||
|
description: tool.resultSummary,
|
||||||
|
status: "complete",
|
||||||
|
}));
|
||||||
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user